Skip to content

[macOS] Eliminate explicit main window init() #123571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 28, 2023
Merged

[macOS] Eliminate explicit main window init() #123571

auto-submit merged 1 commit into from
Mar 28, 2023

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Mar 27, 2023

The style guide actively recommends against calling .init().
See: https://google.github.io/swift/#initializers-1

No additional tests since this is purely a style change with no semantic effect.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
[macOS] Eliminate explicit main window init()
8136171 
The style guide actively recommends against calling .init().

https://google.github.io/swift/#initializers-1

No additional tests since this is purely a style change with no semantic
effect.
@cbracken cbracken requested a review from hellohuanlin March 27, 2023 23:55
@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 27, 2023
hellohuanlin
hellohuanlin approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@hellohuanlin hellohuanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test not needed since it's just style change (but may still need to request test exempt)

@cbracken
Copy link
Member Author

cbracken commented Mar 28, 2023

Fortunately it cleans up a bunch of tests, so the bot won't trigger.

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2023
@cbracken cbracken mentioned this pull request Mar 28, 2023
Merged
8 tasks
@auto-submit auto-submit bot merged commit b0ad7c4 into flutter:master Mar 28, 2023
@cbracken cbracken deleted the no-explicit-init-call branch March 28, 2023 03:32
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
b0ad7c4 [macOS] Eliminate explicit main window init() (flutter/flutte…
159119b 
…r#123571)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
b0ad7c4 [macOS] Eliminate explicit main window init() (flutter/flutte…
a752470 
…r#123571)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
b0ad7c4 [macOS] Eliminate explicit main window init() (flutter/flutte…
fde4e23 
…r#123571)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
b0ad7c4 [macOS] Eliminate explicit main window init() (flutter/flutte…
0f2ede1 
…r#123571)
This was referenced Mar 28, 2023
Merged
Merged
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
b0ad7c4 [macOS] Eliminate explicit main window init() (flutter/flutte…
e972211 
…r#123571)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
b0ad7c4 [macOS] Eliminate explicit main window init() (flutter/flutte…
1e1ef72 
…r#123571)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellohuanlin hellohuanlin hellohuanlin approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbracken @hellohuanlin