Skip to content

[macOS] platform_channel sample style cleanups #123569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Mar 28, 2023
Merged

[macOS] platform_channel sample style cleanups #123569

auto-submit merged 3 commits into from
Mar 28, 2023

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Mar 27, 2023 •
edited
Loading

Applies a few Swift style cleanups to the macOS platform_channel sample.

Also adds ChannelName, BatteryState, ErrorCode enums to bring the example a bit closer to the iOS Swift example. Will follow up with a patch that applies relevant style fixes to the iOS Swift example.

No test changes since app semantics have not changed.

Issue: #79204

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
[macOS] platform_channel sample style cleanups
421c0fd 
Applies a few Swift style cleanups to the macOS platform_channel sample.

Also adds ChannelName, BatteryState, ErrorCode enums to bring the
example a bit closer to the iOS Swift example. Will follow up with a
patch that applies relevant style fixes to the iOS Swift example.

No test changes since app semantics have not changed.

Issue: flutter#79204
@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 27, 2023
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 27, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@cbracken cbracken requested a review from hellohuanlin March 27, 2023 23:43
hellohuanlin
hellohuanlin approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@hellohuanlin hellohuanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need to request test exempt to land. The unit test is not needed since it's example code.

cbracken added 2 commits March 27, 2023 17:03
@cbracken
Make sources final
c20c488
@cbracken
Revert enums
49a95b1 
Added to make it similar to the iOS swift example, but it's inconsistent
with the rest of the samples, irrelevant to demonstrating channels, and
makes it so the useful code is all hidden below the fold, so to speak.
@Hixie
Copy link
Contributor

Hixie commented Mar 28, 2023

test-exempt: code refactor with no semantic change

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2023
@auto-submit auto-submit bot merged commit 99146c2 into flutter:master Mar 28, 2023
@cbracken cbracken deleted the platformchannel-cleanups branch March 28, 2023 03:31
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
99146c2 [macOS] platform_channel sample style cleanups (flutter/flutt…
6f64da8 
…er#123569)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
99146c2 [macOS] platform_channel sample style cleanups (flutter/flutt…
a63ebcb 
…er#123569)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
99146c2 [macOS] platform_channel sample style cleanups (flutter/flutt…
dcec44f 
…er#123569)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
99146c2 [macOS] platform_channel sample style cleanups (flutter/flutt…
5c0cc3c 
…er#123569)
This was referenced Mar 28, 2023
Merged
Merged
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
99146c2 [macOS] platform_channel sample style cleanups (flutter/flutt…
004494f 
…er#123569)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
99146c2 [macOS] platform_channel sample style cleanups (flutter/flutt…
edaabd1 
…er#123569)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellohuanlin hellohuanlin hellohuanlin approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbracken @Hixie @hellohuanlin