Do not animate `TabBarView` if controller is invalid #123442

gilnobrega · 2023-03-25T01:03:34Z

An exception is raised by TabBar when its TabController gets replaced with another controller while it is animating between two tabs.

This happens because the method _handleScrollNotification in _TabBarViewState tries to set _controller.offset value, which setter depends on a non-nullable _controller.animation.
However, this Animation is null if _controller.dispose() is called, e.g.: when the controller is replaced with another controller.

This merge request prevents calling _controller.offset if a pre-existing boolean _controllerIsValid condition is not met in the _handleScrollNotification method.

Fixes issue #34744

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

flutter-dashboard · 2023-03-25T01:03:38Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard · 2023-04-20T21:46:28Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

HansMuller · 2023-05-05T15:17:49Z

This looks OK, just needs a fix for the analyzer errors.

HansMuller · 2023-05-05T16:04:21Z

BTW: you can check for analyzer errors locally with flutter analyze --flutter-repo

gilnobrega · 2023-05-05T16:26:35Z

BTW: you can check for analyzer errors locally with flutter analyze --flutter-repo

Thanks, I was trying to make sense of what those logs in analyze-linux meant, then I noticed Cirrus CI shows the full log

HansMuller

LGTM

…/flutter#123442)

flutter/flutter@077d644...ab57304 2023-05-20 [email protected] Roll Flutter Engine from 482c99af9c69 to aac09195688d (1 revision) (flutter/flutter#127241) 2023-05-20 [email protected] Reland "[tool] Move Java functions to their own file" (flutter/flutter#126577) 2023-05-20 [email protected] Roll Flutter Engine from f0c02aee69db to 482c99af9c69 (1 revision) (flutter/flutter#127240) 2023-05-19 [email protected] Do not animate `TabBarView` if controller is invalid (flutter/flutter#123442) 2023-05-19 [email protected] Run Mac intel only targets on both intel and arm (flutter/flutter#127230) 2023-05-19 [email protected] [Windows] Ensure window is shown (flutter/flutter#127046) 2023-05-19 [email protected] Roll Flutter Engine from 3267fa29491a to f0c02aee69db (4 revisions) (flutter/flutter#127233) 2023-05-19 [email protected] Roll Flutter Engine from 2b14f8a1f21c to 3267fa29491a (4 revisions) (flutter/flutter#127224) 2023-05-19 [email protected] fixes to anticipate next Dart linter release (flutter/flutter#127211) 2023-05-19 [email protected] Remove deprecated OverscrollIndicatorNotification.disallowGlow (flutter/flutter#127050) 2023-05-19 [email protected] Roll Flutter Engine from f471b37a2146 to 2b14f8a1f21c (1 revision) (flutter/flutter#127221) 2023-05-19 [email protected] [flutter_tools] only try to take a screenshot from flutter drive if the --screenshot flag is passed (flutter/flutter#127150) 2023-05-19 [email protected] Roll goldctl to f808dcff91b221ae313e540c09d79696cd08b8de (flutter/flutter#127218) 2023-05-19 [email protected] Roll Packages from b31a128 to 1e214d7 (3 revisions) (flutter/flutter#127217) 2023-05-19 [email protected] Roll Flutter Engine from a0ea4d2d9ea5 to f471b37a2146 (1 revision) (flutter/flutter#127212) 2023-05-19 [email protected] Revert "Migrate benchmarks to package:web" (flutter/flutter#127207) 2023-05-19 [email protected] [tool] delete xcresult bundle file before each xcode retry. (flutter/flutter#127144) 2023-05-19 [email protected] [iOS] Dispose of log readers and port forwarders if launch fails (flutter/flutter#127140) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…/flutter#123442)

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 25, 2023

gilnobrega force-pushed the replace_tabcontroller_mid_animation branch 5 times, most recently from 695afed to 002b201 Compare March 30, 2023 14:58

HansMuller self-requested a review March 31, 2023 21:42

gilnobrega force-pushed the replace_tabcontroller_mid_animation branch from 002b201 to 112e4a4 Compare April 21, 2023 07:37

gilnobrega force-pushed the replace_tabcontroller_mid_animation branch from 112e4a4 to d534e14 Compare May 4, 2023 23:27

gilnobrega force-pushed the replace_tabcontroller_mid_animation branch from 8375805 to f3c08e9 Compare May 5, 2023 15:47

gilnobrega added 4 commits May 11, 2023 21:54

dont handle notification if controller invalid

13e345f

test: replace tabcontroller while flinging

93f816c

remove unnecessary space

fbf5a90

fix analyzer issues

52ffda6

gilnobrega force-pushed the replace_tabcontroller_mid_animation branch from 6f63e8e to 52ffda6 Compare May 11, 2023 20:54

HansMuller and others added 2 commits May 12, 2023 08:33

Merge branch 'master' into replace_tabcontroller_mid_animation

ef640f3

Merge branch 'master' into replace_tabcontroller_mid_animation

db7ae25

HansMuller approved these changes May 19, 2023

View reviewed changes

HansMuller merged commit 7b16cbc into flutter:master May 19, 2023

engine-flutter-autoroll mentioned this pull request May 20, 2023

Roll Flutter from 077d644bbc5f to 80a4f9b15917 (17 revisions) flutter/packages#4047

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2023

7b16cbc Do not animate TabBarView if controller is invalid (flutter…

5ca0647

…/flutter#123442)

engine-flutter-autoroll mentioned this pull request May 20, 2023

Roll Flutter from 077d644bbc5f to ab573048e74d (18 revisions) flutter/packages#4048

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2023

7b16cbc Do not animate TabBarView if controller is invalid (flutter…

dad79b2

…/flutter#123442)

engine-flutter-autoroll mentioned this pull request May 21, 2023

Roll Flutter from 077d644bbc5f to ab573048e74d (18 revisions) flutter/packages#4050

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2023

7b16cbc Do not animate TabBarView if controller is invalid (flutter…

05e06fc

…/flutter#123442)

engine-flutter-autoroll mentioned this pull request May 21, 2023

Roll Flutter from 077d644bbc5f to ab573048e74d (18 revisions) flutter/packages#4051

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2023

7b16cbc Do not animate TabBarView if controller is invalid (flutter…

3d86bc5

…/flutter#123442)

CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023

Do not animate TabBarView if controller is invalid (flutter#123442)

e0c4222

This was referenced May 25, 2023

Support minifcation for apps that depend on AGP 8 and integration_test #127628

Merged

i127682 android api 33 test support #127689

Merged

HansMuller mentioned this pull request May 26, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

7b16cbc Do not animate TabBarView if controller is invalid (flutter…

732e2d8

…/flutter#123442)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

7b16cbc Do not animate TabBarView if controller is invalid (flutter…

35991c9

…/flutter#123442)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

7b16cbc Do not animate TabBarView if controller is invalid (flutter…

bbd3a22

…/flutter#123442)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

7b16cbc Do not animate TabBarView if controller is invalid (flutter…

d03f45e

…/flutter#123442)

bleroux mentioned this pull request Jul 7, 2025

Replacing TabController mid-animation throws exception #34744

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Do not animate `TabBarView` if controller is invalid #123442

Do not animate `TabBarView` if controller is invalid #123442

Uh oh!

gilnobrega commented Mar 25, 2023

Uh oh!

flutter-dashboard bot commented Mar 25, 2023

Uh oh!

flutter-dashboard bot commented Apr 20, 2023

Uh oh!

HansMuller commented May 5, 2023

Uh oh!

HansMuller commented May 5, 2023 •

edited

Loading

Uh oh!

gilnobrega commented May 5, 2023

Uh oh!

HansMuller left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Do not animate TabBarView if controller is invalid #123442

Do not animate TabBarView if controller is invalid #123442

Uh oh!

Conversation

gilnobrega commented Mar 25, 2023

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Mar 25, 2023

Uh oh!

flutter-dashboard bot commented Apr 20, 2023

Uh oh!

HansMuller commented May 5, 2023

Uh oh!

HansMuller commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gilnobrega commented May 5, 2023

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Do not animate `TabBarView` if controller is invalid #123442

Do not animate `TabBarView` if controller is invalid #123442

HansMuller commented May 5, 2023 •

edited

Loading