Fix Animations in NavigationDestination icons don't work #123400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
bleroux
force-pushed
the
fix_animations_in_NavigationDestination_icons_do_not_work
branch
from
f5a680c to
3c78416
Compare
HansMuller
approved these changes
Mar 27, 2023
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
Another nice fix! LGTM
bleroux
deleted the
fix_animations_in_NavigationDestination_icons_do_not_work
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2023
8 tasks
This was referenced Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes _NavigationDestinationBuilder to avoid unexpected rebuild.
Using the code sample provided in #122811 (comment), results are:
Before (icon color changes on every tap and icon animation shows only initial and final states)
122811_repro.mp4
After (icon color stays the same on tap and icon animation works as expected)
Capture.video.du.2023-03-24.14-18-42.mp4
Related Issue
Fixes #122811
Tests
Adds 1 test.