Skip to content

[flutter_tools] Remove --no-sound-null-safety #3 #123297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 16 commits into from
Mar 29, 2023
Merged

[flutter_tools] Remove --no-sound-null-safety #3 #123297

auto-submit merged 16 commits into from
Mar 29, 2023

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Mar 22, 2023 •
edited
Loading

Part of #118837
Fixes #118810

The previous attempt, #123031, was reverted because some Google-specific workflows relied on being able to build non-null-safe apps.

This re-land leaves the top-level flag, while hiding it and throwing a tool exit if it ever used, unless a new context getter globals.nonNullSafeBuilds evaluates to NonNullSafeBuilds.notAllowed, which will only be provided in Google-specific workflows.

cl/519269413 is the internal fix that will override globals.nonNullSafeBuilds.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 22, 2023
@christopherfujino christopherfujino force-pushed the re-land-no-sound-null-safety branch from 6b1c456 to 5ca3f42 Compare March 22, 2023 22:59
@christopherfujino christopherfujino changed the title [flutter_tools] Re-land remvoe --no-sound-null-safety #3 [flutter_tools] Re-land remove --no-sound-null-safety #3 Mar 22, 2023
@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 22, 2023
@goderbauer goderbauer mentioned this pull request Mar 23, 2023
Closed
23 tasks
@christopherfujino christopherfujino changed the title [flutter_tools] Re-land remove --no-sound-null-safety #3 [flutter_tools] Remove --no-sound-null-safety #3 Mar 25, 2023
@christopherfujino christopherfujino mentioned this pull request Mar 25, 2023
Closed
@christopherfujino christopherfujino marked this pull request as ready for review March 25, 2023 03:00
andrewkolos
andrewkolos approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; waiting for cl/519269413

eliasyishak
eliasyishak approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@eliasyishak eliasyishak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkolos
Copy link
Contributor

andrewkolos commented Mar 28, 2023 •
edited
Loading

I updated this branch to try to get Google testing unstuck, but now two checks are failing on recently-added Clipboard.getData tests. I get the same failures when running on master (and even the commit that introduced the tests), which is weird because recent PRs have had these tests pass.

Command I'm using to run the tests (from the packages/flutter directory): flutter test test/services/clipboard_test.dart --platform=chrome --web-renderer=canvaskit

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
730b95e 
…ter/flutter#123297)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
948e171 
…ter/flutter#123297)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
9555615 
…ter/flutter#123297)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
defb6f9 
…ter/flutter#123297)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
7cb2b05 
…ter/flutter#123297)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
26166a7 
…ter/flutter#123297)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
16c5a2e 
…ter/flutter#123297)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
beca6b7 
…ter/flutter#123297)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
347fcee 
…ter/flutter#123297)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
3595efe 
…ter/flutter#123297)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
c9b8e35 
…ter/flutter#123297)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
df8a33e 
…ter/flutter#123297)
@reidbaker reidbaker mentioned this pull request Apr 1, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
f9804c5 
…ter/flutter#123297)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
1ad839b 
…ter/flutter#123297)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
acdf66f 
…ter/flutter#123297)
CaseyHillers added a commit that referenced this pull request Apr 2, 2023
@CaseyHillers
Revert "[flutter_tools] Remove --no-sound-null-safety #3 (#123297)"
557799b 
This reverts commit 820ec70.
@CaseyHillers CaseyHillers mentioned this pull request Apr 2, 2023
Merged
@christopherfujino christopherfujino mentioned this pull request Apr 3, 2023
Merged
@christopherfujino christopherfujino deleted the re-land-no-sound-null-safety branch April 3, 2023 17:56
CaseyHillers pushed a commit that referenced this pull request Apr 4, 2023
@christopherfujino
[flutter_tools] Remove --no-sound-null-safety #4 (#124039)
b2c65ac 
Re-land of #123297 without any of
the commits at the end attempting to fix customer-testing.

Fixes #118810
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@christopherfujino @exaby73
[flutter_tools] Remove --no-sound-null-safety #3 (flutter#123297)
23dd1e7 
[flutter_tools] Remove --no-sound-null-safety #3
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@christopherfujino @exaby73
[flutter_tools] Remove --no-sound-null-safety #4 (flutter#124039)
178d99b 
Re-land of flutter#123297 without any of
the commits at the end attempting to fix customer-testing.

Fixes flutter#118810
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
25dbcfc 
…ter/flutter#123297)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
820ec70 [flutter_tools] Remove --no-sound-null-safety flutter#3 (flut…
53364d7 
…ter/flutter#123297)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

@andrewkolos andrewkolos andrewkolos approved these changes

+1 more reviewer

@eliasyishak eliasyishak eliasyishak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove option to pass unsound null safety flag in flutter build/run commands

4 participants

@christopherfujino @andrewkolos @zanderso @eliasyishak