-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Workaround for exhaustiveness bug in dart2js #123242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
b93d906 to
d639821
Compare
|
dart-lang/sdk#51823 is the issue on the dart side of things |
|
\cc @itsjustkevin this should be included in the next roll, otherwise it will need to be locally applied |
This reverts commit f68a676.
…flutter#123727) Revert "Workaround for exhaustivness bug in dart2js (flutter#123242)"
#123243
This was failing in google3. Dart team is working on root causing & fixing this.