Skip to content

manual pub roll #123071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Mar 21, 2023
Merged

manual pub roll #123071

auto-submit merged 2 commits into from
Mar 21, 2023

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Mar 20, 2023 •
edited
Loading

Manual roll to pick up a fix in vm_service, and also re-enable skipped tests from #123019 (see #123018 (comment))

Fixes #123018

@christopherfujino
Revert "Skip web hot restart tests (flutter#123019)"
cb738a1 
Re-enable hot restart tests that should be fixed by a vm_service bump.

This reverts commit e6e99e2.
@christopherfujino
roll pub dependencies
0ea6744
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 20, 2023
goderbauer
goderbauer approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 20, 2023
@goderbauer goderbauer mentioned this pull request Mar 20, 2023
Merged
@christopherfujino christopherfujino mentioned this pull request Mar 21, 2023
Closed
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 21, 2023

auto label is removed for flutter/flutter, pr: 123071, due to - The status or check suite Mac plugin_lint_mac has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot merged commit 6b7c60d into flutter:master Mar 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2023
@engine-flutter-autoroll
6b7c60d manual pub roll (flutter/flutter#123071)
f515843
@christopherfujino christopherfujino deleted the roll-vm-service branch March 21, 2023 17:33
@annagrin annagrin mentioned this pull request Mar 24, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
6b7c60d manual pub roll (flutter/flutter#123071)
e5ee344
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
6b7c60d manual pub roll (flutter/flutter#123071)
8f7a0f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mac web_tool_tests has become very flaky

2 participants

@christopherfujino @goderbauer