Skip to content

Remove unused replacement from Visibility.maintain #123039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Mar 20, 2023
Merged

Remove unused replacement from Visibility.maintain #123039

auto-submit merged 2 commits into from
Mar 20, 2023

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Mar 20, 2023

While reviewing #122585 I noticed that the replacement parameter on Visibility.maintain doesn't make any sense. It is always ignored because the constructor forces maintainState to true:

flutter/packages/flutter/lib/src/widgets/visibility.dart

Lines 139 to 140 in e0ea39f

/// If this property is true, an [Offstage] widget is used to hide the child
/// instead of replacing it with [replacement].

Therefore, this PR removed the replacement parameter from Visibility.maintain.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 20, 2023
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 20, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@tvolkert
Copy link
Contributor

tvolkert commented Mar 20, 2023

LGTM, but dartdocs for Visibility.maintain() need to be updated too.

@goderbauer
Copy link
Member Author

goderbauer commented Mar 20, 2023

Ah, right. Updated by removing that line altogether. Since we don't support non-nullsafe mode anymore, the note about child not being null is also redundant.

@Hixie
Copy link
Contributor

Hixie commented Mar 20, 2023

test-exempt: removing code

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 20, 2023
@auto-submit auto-submit bot merged commit c4a81e9 into flutter:master Mar 20, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2023
@engine-flutter-autoroll
c4a81e9 Remove unused replacement from Visibility.maintain (flutter/f…
07635cd 
…lutter#123039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
c4a81e9 Remove unused replacement from Visibility.maintain (flutter/f…
beec9ba 
…lutter#123039)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
c4a81e9 Remove unused replacement from Visibility.maintain (flutter/f…
f6319f9 
…lutter#123039)
@goderbauer goderbauer deleted the removeReplacement branch July 13, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

1 more reviewer

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goderbauer @tvolkert @Hixie