Fix error message for unbounded viewports #123035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
added
framework
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter, pr: 123035, due to - The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2023
Piinks
commented
Apr 17, 2023
|
|
||
| testWidgets('Shrinkwrapping viewport asserts bounded cross axis', (WidgetTester tester) async { | ||
| final List<FlutterErrorDetails> errors = <FlutterErrorDetails>[]; | ||
| FlutterError.onError = (FlutterErrorDetails error) => errors.add(error); |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a common debug method for checking that a viewport has bounded constraints. Provides a clean and clear error message everywhere that we check for this. There was already an excellent check and error message written for this in computeDryLayout, so I moved it to be shared.
Fixes #78796
I did not make this debug method part of the viewport class because it can be used in the 2D viewport as well later. :)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.