[flutter_tools] Remove sound null safety flag #2 #123031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
framework
zanderso
approved these changes
Mar 20, 2023
christopherfujino
added
the
autosubmit
auto-submit
bot
deleted the
revert-122909-revert-120936-remove-sound-null-safety-flag
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 21, 2023
… (#120936)" (#122909)" (flutter/flutter#123031)
This was referenced Mar 21, 2023
christopherfujino
added a commit
to chris-forks/flutter
that referenced
this pull request
Mar 22, 2023
This reverts commit f4c3fac.
This was referenced Mar 28, 2023
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
… (#120936)" (#122909)" (flutter/flutter#123031)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
… (#120936)" (#122909)" (flutter/flutter#123031)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-land of #120936
which was reverted in #122909 because of a framework smoke test in the engine tree that relied on a flag deleted from that PR: https://ci.chromium.org/p/flutter/builders/prod/Linux%20Framework%20Smoke%20Tests/10684
The recipe was fixed upstream in https://flutter-review.googlesource.com/c/recipes/+/40800