Skip to content

Conversation

@zanderso
Copy link
Member

@flutter-dashboard flutter-dashboard bot added the engine flutter/engine related. See also e: labels. label Mar 18, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@zanderso zanderso requested a review from gaaclarke March 18, 2023 15:06
@zanderso zanderso added warning: land on red to fix tree breakage revert Autorevert PR (with "Reason for revert:" comment) labels Mar 18, 2023
@auto-submit auto-submit bot merged commit cd19817 into master Mar 18, 2023
@auto-submit auto-submit bot deleted the revert-122942-flutter-engine-flutter-autoroll-79b55121-5e59-4eca-9293-4dc1020b62a6-1679116989 branch March 18, 2023 15:07
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels. revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants