Skip to content

[Tool] [Windows] Output app path on build completion #122928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Mar 20, 2023
Merged

[Tool] [Windows] Output app path on build completion #122928

auto-submit merged 2 commits into from
Mar 20, 2023

Conversation

@loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Mar 17, 2023 •
edited
Loading

⚠️ This re-lands #122858 after it was reverted by #122926. The fix is c098e6f (#122928): it uses CMake's app name instead of pubspec.yaml's app name as these can get out of sync.

Improves the build output:

  1. Gives confirmation that the build succeeded
  2. Gives the path to the built executable

This matches the behavior of other Flutter platforms like Android.

Part of #120127

Flutter run

> flutter run -d windows
Launching lib\main.dart on Windows in debug mode...
Building Windows application...                                    11.1s
✓  Built build\windows\runner\Debug\x10.exe.
Syncing files to device Windows...                                  60ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h List all available interactive commands.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).

Flutter build

> flutter build windows
Building Windows application...                                    25.9s
✓  Built build\windows\runner\Release\x10.exe (0.1MB).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 17, 2023
@loic-sharma loic-sharma force-pushed the windowds_output_exe branch from d39f10f to 32e1e11 Compare March 18, 2023 23:26
loic-sharma
loic-sharma commented Mar 18, 2023
View reviewed changes
packages/flutter_tools/lib/src/windows/build_windows.dart Outdated
Copy link
Member Author

@loic-sharma loic-sharma Mar 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reland's fix. The original change used the app's name according to the pubspec.yaml file and assumed that matched CMake's app name. However, these files can get out of sync.

@loic-sharma loic-sharma marked this pull request as ready for review March 19, 2023 01:34
christopherfujino
christopherfujino approved these changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loic-sharma loic-sharma force-pushed the windowds_output_exe branch from 32e1e11 to c098e6f Compare March 20, 2023 18:13
@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 20, 2023
@auto-submit auto-submit bot merged commit 2312097 into flutter:master Mar 20, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2023
@engine-flutter-autoroll
2312097 [Tool] [Windows] Output app path on build completion (flutter…
54ae74c 
…/flutter#122928)
@loic-sharma loic-sharma deleted the windowds_output_exe branch March 21, 2023 18:59
@loic-sharma loic-sharma mentioned this pull request Mar 21, 2023
Closed
cbracken
cbracken reviewed Mar 22, 2023
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
2312097 [Tool] [Windows] Output app path on build completion (flutter…
e6945f2 
…/flutter#122928)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
2312097 [Tool] [Windows] Output app path on build completion (flutter…
91db202 
…/flutter#122928)
@guidezpl guidezpl mentioned this pull request Jun 10, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken left review comments

@yaakovschectman yaakovschectman Awaiting requested review from yaakovschectman

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@loic-sharma @cbracken @christopherfujino