Cherry pick: iOS context menu positioning #122907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r#119565) * Fix anchorBelow calculation, and share toolbar padding constant * Fix constant references in test * Test below position when padding is not offset by content distance
flutter-dashboard
bot
added
a: text input
Contributor
|
the codesign failures are expected, but I am not sure about the the linux docs_test failure |
XilaiZhang
approved these changes
Mar 17, 2023
Contributor
XilaiZhang
left a comment
XilaiZhang
left a comment
There was a problem hiding this comment.
would be great if can verify with @godofredoc on the linux doc test
Contributor
Author
|
Ah those docs errors are artifacts of the merge, those classes truly don't exist yet. I just removed them. |
itsjustkevin
approved these changes
Mar 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry picks #119565, which was a small fix to the math that positions the iOS text selection toolbar when it's too close to the top of the screen. This should be a low-risk change.
Some changes in that PR were made to files that don't exist yet in this candidate branch, so I have ignored those changes.
Closes #121307
CC @limenote135