Skip to content

Conversation

@TahaTesser
Copy link
Member

fixes #122471

code sample
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Builder(builder: (BuildContext context) {
          return FilledButton(
            onPressed: () async {
              await showTimePicker(
                initialTime: TimeOfDay.now(),
                initialEntryMode: TimePickerEntryMode.input,
                context: context,
              );
            },
            child: const Text('Open Time Picker'),
          );
        }),
      ),
    );
  }
}

Before

Preview

After

Preview

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 17, 2023
@TahaTesser TahaTesser requested a review from gspencergoog March 17, 2023 07:59
@gspencergoog
Copy link
Contributor

Not sure why, but the cocoon golden test is failing with this change. I didn't think it had a time picker, but maybe?

@TahaTesser TahaTesser force-pushed the fix_time_picker_width branch from 9104eb0 to 46b4484 Compare March 20, 2023 08:27
@TahaTesser
Copy link
Member Author

Not sure why, but the cocoon golden test is failing with this change. I didn't think it had a time picker, but maybe?

Just rebased. All green.

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 20, 2023
@auto-submit auto-submit bot merged commit 8679aeb into flutter:master Mar 20, 2023
@TahaTesser TahaTesser deleted the fix_time_picker_width branch March 20, 2023 18:34
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

M3 TimePicker input mode has incorrect spacing and mode icon position is bit off

2 participants