Skip to content

Conversation

@loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Mar 17, 2023

Improves the build output:

  1. Gives confirmation that the build succeeded
  2. Gives the path to the built executable

This matches the behavior of other Flutter platforms like Android.

Part of #120127

Flutter run

> flutter run -d windows
Launching lib\main.dart on Windows in debug mode...
Building Windows application...                                    11.1s
✓  Built build\windows\runner\Debug\x10.exe.
Syncing files to device Windows...                                  60ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h List all available interactive commands.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).

Flutter build

> flutter build windows
Building Windows application...                                    25.9s
✓  Built build\windows\runner\Release\x10.exe (0.1MB).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 17, 2023
@loic-sharma loic-sharma marked this pull request as ready for review March 17, 2023 17:26
@loic-sharma loic-sharma changed the title [Windows] Improve build output [Tool] [Windows] Output app path on build completion Mar 17, 2023
@loic-sharma loic-sharma force-pushed the windowds_output_exe branch from d1f576e to d39f10f Compare March 17, 2023 17:32
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2023
@auto-submit auto-submit bot merged commit 80d6c10 into flutter:master Mar 17, 2023
loic-sharma added a commit that referenced this pull request Mar 17, 2023
auto-submit bot pushed a commit that referenced this pull request Mar 17, 2023
…" (#122926)

Revert "[Tool] [Windows] Output app path on build completion"
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants