Revert "Fix hot restart flake" #122855
Merged
Revert "Fix hot restart flake" #122855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 62171df.
flutter-dashboard
bot
added
the
tool
Contributor
Author
loic-sharma
approved these changes
Mar 17, 2023
Contributor
|
@christopherfujino do we have a timeout somewhere for one test file not to exceed 30 minutes? I think I added too many tests:) Will split them up and try to re-land after this revert is in. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 17, 2023
Contributor
Author
Ahh you're right, looks like even when this passes it's just under the timeout. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #122776 because this test is sometimes hanging for example: https://ci.chromium.org/ui/p/flutter/builders/try/Windows%20web_tool_tests_1_2/5036/overview