Skip to content

Revert "Fix bug with clicking Copy or Select All within contextMenu" #122832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 16, 2023
Merged

Revert "Fix bug with clicking Copy or Select All within contextMenu" #122832

auto-submit merged 1 commit into from
Mar 16, 2023

Conversation

@yaakovschectman
Copy link
Contributor

@yaakovschectman yaakovschectman commented Mar 16, 2023

Reverts #120081

Fails Linux web_tests_1 with failing test description: test/widgets/selectable_region_test.dart: the selection behavior when clicking Copy item in mobile platforms [E]

@yaakovschectman yaakovschectman added the revert Autorevert PR (with "Reason for revert:" comment) label Mar 16, 2023
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 16, 2023
@yaakovschectman yaakovschectman mentioned this pull request Mar 16, 2023
Closed
christopherfujino
christopherfujino approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot merged commit 6711411 into master Mar 16, 2023
@auto-submit auto-submit bot deleted the revert-120081-selection-overlay-issue branch March 16, 2023 20:35
@auto-submit auto-submit bot mentioned this pull request Mar 16, 2023
Closed
@justinmc
Copy link
Contributor

justinmc commented Mar 16, 2023 •
edited
Loading

@acumen1005 It looks like the test you wrote in #120081 failed when running on Linux. Could you take a look? I think it might be we just forgot to update the expectation in the test after changing the behavior.

You could try specifying the platform when you run the test like flutter test --platform linux.

If you can fix it, please open a new PR by clicking the "Revert" button on this PR.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2023
@engine-flutter-autoroll
6711411 Revert "Fix bug with clicking Copy or Select All within c…
1fa3e36 
…ontextMenu (#120081)" (flutter/flutter#122832)
acumen1005 added a commit to acumen1005/flutter that referenced this pull request Mar 19, 2023
@acumen1005
Revert "Revert "Fix bug with clicking Copy or Select All within c…
163220e 
…ontextMenu (flutter#120081)" (flutter#122832)"

This reverts commit 6711411.
@acumen1005 acumen1005 mentioned this pull request Mar 19, 2023
Merged
@acumen1005
Copy link
Contributor

acumen1005 commented Mar 19, 2023

@acumen1005 It looks like the test you wrote in #120081 failed when running on Linux. Could you take a look? I think it might be we just forgot to update the expectation in the test after changing the behavior.

You could try specifying the platform when you run the test like flutter test --platform linux.

If you can fix it, please open a new PR by clicking the "Revert" button on this PR.

I have added skip: kIsWeb in the failure test case, and All checks have passed in the new PR.

@justinmc
Copy link
Contributor

justinmc commented Mar 20, 2023

Ah right, thank you!

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
6711411 Revert "Fix bug with clicking Copy or Select All within c…
fb1c8d0 
…ontextMenu (#120081)" (flutter/flutter#122832)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
6711411 Revert "Fix bug with clicking Copy or Select All within c…
977cfad 
…ontextMenu (#120081)" (flutter/flutter#122832)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

@justinmc justinmc Awaiting requested review from justinmc

@chunhtai chunhtai Awaiting requested review from chunhtai

@hannah-hyj hannah-hyj Awaiting requested review from hannah-hyj

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yaakovschectman @justinmc @acumen1005 @christopherfujino @fluttergithubbot