Skip to content

Revert "Assert that runApp is called in the same zone as binding.ensureInitialized" #122830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 16, 2023
Merged

Revert "Assert that runApp is called in the same zone as binding.ensureInitialized" #122830

auto-submit merged 1 commit into from
Mar 16, 2023

Conversation

@yaakovschectman
Copy link
Contributor

@yaakovschectman yaakovschectman commented Mar 16, 2023

Reverts #117113

Linux web_canvaskit_tests_0 and Mac web_tool_tests are failing.

@yaakovschectman yaakovschectman added the revert Autorevert PR (with "Reason for revert:" comment) label Mar 16, 2023
@yaakovschectman yaakovschectman requested a review from Hixie March 16, 2023 20:26
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 16, 2023
@auto-submit auto-submit bot merged commit 5bea4d9 into master Mar 16, 2023
@auto-submit auto-submit bot deleted the revert-117113-zones branch March 16, 2023 20:29
@auto-submit auto-submit bot mentioned this pull request Mar 16, 2023
Closed
@yaakovschectman yaakovschectman mentioned this pull request Mar 16, 2023
Closed
@Hixie Hixie mentioned this pull request Mar 16, 2023
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2023
@engine-flutter-autoroll
5bea4d9 Revert "Assert that runApp is called in the same zone as bind…
d88b23e 
…ing.ensureInitialized (#117113)" (flutter/flutter#122830)
Hixie
Hixie reviewed Mar 23, 2023
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
5bea4d9 Revert "Assert that runApp is called in the same zone as bind…
260cd53 
…ing.ensureInitialized (#117113)" (flutter/flutter#122830)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
5bea4d9 Revert "Assert that runApp is called in the same zone as bind…
abb3b75 
…ing.ensureInitialized (#117113)" (flutter/flutter#122830)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie left review comments

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yaakovschectman @Hixie @fluttergithubbot