Skip to content

Use packages/packages recipe. #122822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 16, 2023
Merged

Use packages/packages recipe. #122822

auto-submit merged 1 commit into from
Mar 16, 2023

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Mar 16, 2023

Packages_v2 and packages are now the same in preparation to remove the v2 portion of the recipe's name. Packages_v2 will be removed after this change is CP'ed to beta and stable.

Bug: #121735

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Use packages/packages recipe.
d8e6a67 
Packages_v2 and packages are now the same in preparation to remove the
v2 portion of the recipe's name. Packages_v2 will be removed after this
change is CP'ed to beta and stable.

Bug: #121735
@godofredoc godofredoc requested a review from sealesj March 16, 2023 19:24
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 16, 2023
@auto-submit auto-submit bot merged commit 9f35ed7 into flutter:master Mar 16, 2023
godofredoc added a commit that referenced this pull request Mar 16, 2023
@godofredoc
CP: Use packages/packages recipe. (#122822) (#122842)
d477bcc 
* Use packages/packages recipe. (#122822)

Use packages/packages recipe.

* Fix conflicts.

* Do not add tests that didn't exist.

* Remove name change caused by conflict resolution.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2023
@engine-flutter-autoroll
9f35ed7 Use packages/packages recipe. (flutter/flutter#122822)
801321e
godofredoc added a commit that referenced this pull request Mar 17, 2023
@godofredoc
Use packages/packages recipe. (#122822) (#122844)
c3882b0 
Use packages/packages recipe.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
9f35ed7 Use packages/packages recipe. (flutter/flutter#122822)
0620ac5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
9f35ed7 Use packages/packages recipe. (flutter/flutter#122822)
898668e
@godofredoc godofredoc deleted the use_new_packages branch January 5, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sealesj sealesj sealesj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @sealesj