Skip to content

Refactors accessibility guidelines to remove the single window assumption #122760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 17, 2023
Merged

Refactors accessibility guidelines to remove the single window assumption #122760

auto-submit merged 1 commit into from
Mar 17, 2023

Conversation

@pdblasi-google
Copy link
Contributor

@pdblasi-google pdblasi-google commented Mar 15, 2023 •
edited
Loading

Refactors accessibility guidelines to remove the single window assumption.

  • Guidelines will now test all views available

Resolves #119364

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Mar 15, 2023
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 15, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@pdblasi-google pdblasi-google mentioned this pull request Mar 15, 2023
Open
@pdblasi-google
Copy link
Contributor Author

pdblasi-google commented Mar 15, 2023 •
edited
Loading

Currently, there's no way to set up a multi-view app to run new tests against the AccessibilityGuidelines adjusted here.

All existing tests pass, confirming that no single-view functionality (that was previously tested) was broken, and I've created #122762 to keep track of the need for multi-view tests.

Hixie
Hixie reviewed Mar 15, 2023
View reviewed changes
Hixie
Hixie reviewed Mar 15, 2023
View reviewed changes
@Hixie
Copy link
Contributor

Hixie commented Mar 15, 2023

test-exempt: code refactor with no semantic change

goderbauer
goderbauer reviewed Mar 15, 2023
View reviewed changes
goderbauer
goderbauer approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member

goderbauer commented Mar 17, 2023

The customer_testing failure is strange. I wonder, maybe you just have to rebase this PR to make it go away?

@pdblasi-google
Refactors accessibility guidelines to remove the single window assump…
933b09c 
…tion.

* Guidelines will now test _all_ views available
goderbauer
goderbauer approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pdblasi-google pdblasi-google added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2023
@auto-submit auto-submit bot merged commit 399cd6a into flutter:master Mar 17, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2023
@engine-flutter-autoroll
399cd6a Refactors accessibility guidelines to remove the single windo…
a45f3c9 
…w assumption. (flutter/flutter#122760)
@pdblasi-google pdblasi-google deleted the issues/119364 branch March 21, 2023 20:17
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
399cd6a Refactors accessibility guidelines to remove the single windo…
9f8bb62 
…w assumption. (flutter/flutter#122760)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
399cd6a Refactors accessibility guidelines to remove the single windo…
0e6164e 
…w assumption. (flutter/flutter#122760)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie left review comments

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor accessibility guidelines to remove single window assumption

3 participants

@pdblasi-google @Hixie @goderbauer