Skip to content

Remove last few references to window singleton #122644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 15, 2023
Merged

Remove last few references to window singleton #122644

auto-submit merged 1 commit into from
Mar 15, 2023

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Mar 14, 2023

Part of #116929.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin labels Mar 14, 2023
pdblasi-google
pdblasi-google approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@pdblasi-google pdblasi-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 14, 2023
@auto-submit auto-submit bot merged commit a599c08 into flutter:master Mar 15, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
a599c08 Remvoe last few references to window singleton (flutter/flutt…
da73eb5 
…er#122644)
@goderbauer goderbauer deleted the missedWindows branch March 15, 2023 16:22
goderbauer added a commit that referenced this pull request Mar 15, 2023
@goderbauer
Revert "Remvoe last few references to window singleton (#122644)"
0c7e291 
This reverts commit a599c08.
@goderbauer goderbauer mentioned this pull request Mar 15, 2023
Closed
@HansMuller HansMuller mentioned this pull request Mar 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
a599c08 Remvoe last few references to window singleton (flutter/flutt…
7ae0626 
…er#122644)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
a599c08 Remvoe last few references to window singleton (flutter/flutt…
93c6838 
…er#122644)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pdblasi-google pdblasi-google pdblasi-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App f: gestures flutter/packages/flutter/gestures repository. f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goderbauer @pdblasi-google