Skip to content

Revert "Updates flutter/test/material to no longer use TestWindow" #122636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yaakovschectman merged 1 commit into from
Mar 14, 2023
Merged

Revert "Updates flutter/test/material to no longer use TestWindow" #122636

yaakovschectman merged 1 commit into from
Mar 14, 2023

Conversation

@yaakovschectman
Copy link
Contributor

@yaakovschectman yaakovschectman commented Mar 14, 2023

Reverts #122337

@yaakovschectman yaakovschectman added the revert Autorevert PR (with "Reason for revert:" comment) label Mar 14, 2023
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Mar 14, 2023
@yaakovschectman yaakovschectman merged commit 46a8106 into master Mar 14, 2023
@yaakovschectman yaakovschectman deleted the revert-122337-issues/122240 branch March 14, 2023 21:34
@yaakovschectman yaakovschectman mentioned this pull request Mar 14, 2023
Closed
@goderbauer
Copy link
Member

goderbauer commented Mar 14, 2023

@yaakovschectman Could you please update the PR description and give a quick reason for the revert for future archeologists. Thanks.

@pdblasi-google
Copy link
Contributor

pdblasi-google commented Mar 14, 2023

It looks like they added analysis and links to a related issue: #122637

@Hixie Hixie mentioned this pull request Mar 14, 2023
Closed
@yaakovschectman
Copy link
Contributor Author

yaakovschectman commented Mar 15, 2023

@goderbauer this PR may have been an unlucky scapegoat. A separate revert of Skia gold tests has the tree green again.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
46a8106 Revert "Updates flutter/test/material to no longer use `Tes…
6399a33 
…tWindow` (#122337)" (flutter/flutter#122636)
@pdblasi-google
Copy link
Contributor

pdblasi-google commented Mar 15, 2023

@yaakovschectman

Unfortunately, it wasn't a scapegoat. The Skia tests were from the PR you mention, but the build/analysis errors were from merging errors on the original PR that this reverted.

A bunch of PRs all went in at once, so you got two separate commits that would've failed the tree. But because they went in at the same time, tests were skipped on the skia one, leading to it looking like this PR (or the one before it) had caused that error as well.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
46a8106 Revert "Updates flutter/test/material to no longer use `Tes…
1e863c7 
…tWindow` (#122337)" (flutter/flutter#122636)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
46a8106 Revert "Updates flutter/test/material to no longer use `Tes…
00a97b9 
…tWindow` (#122337)" (flutter/flutter#122636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pdblasi-google pdblasi-google pdblasi-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yaakovschectman @goderbauer @pdblasi-google