Set plugin template minimum iOS version to 11.0 #122625

vashworth · 2023-03-14T18:45:02Z

When creating a new package, set the minimum iOS version to 11.0. Also, update integration_test package minimum iOS version to 11.0.

Fixes #101961.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

vashworth · 2023-03-14T22:50:15Z

@jmagman I was working with plugins and noticed this so I thought I'd just fix it, but just discovered you already had the issue for it assigned to you #101961. Hopefully you haven't worked on it yet and this will save you some time.

One thing, in the issue it says:

Up the Flutter SDK constraint to whatever version #101960 ships on to enforce that the 11.0 migration has happened on the app side.

How can I tell which version that shipped with?

jmagman

This would also require the plugin template pubspec to enforce that it can only be used when running Flutter 3.3 or higher, since that's the version where we increased the app minimum version to iOS 11.

environment:
  sdk: ">=2.18.0 <3.0.0"
  flutter: ">=3.3.0"

Otherwise apps running with an older version of Flutter with a 9.0 minimum could try to use the plugin, pub would let since the constraints are fine, and then they would get a native iOS compilation error when the plugin iOS target minimum is too high to be linked on by the app target.

vashworth · 2023-03-15T14:55:28Z

@jmagman How did you know which versions?

Also, looks like the sdk version is now dynamic so I did not change it:

flutter/packages/flutter_tools/templates/plugin_shared/pubspec.yaml.tmpl

Line 7 in fb7e828

sdk: {{dartSdkVersionBounds}}

flutter/packages/flutter_tools/lib/src/commands/create.dart

Line 270 in fb7e828

final String dartSdk = globals.cache.dartSdkBuild;

flutter/packages/flutter_tools/lib/src/commands/create.dart

Line 326 in fb7e828

dartSdkVersionBounds: "'>=$dartSdk <4.0.0'",

jmagman · 2023-03-15T18:08:20Z

@jmagman How did you know which versions?

Actually it's Flutter 3.1, not 3.3. #101963 was first available in 3.1, and that dart version was 2.18.0, so sdk: ">=2.18.0 <3.0.0" is still the right dart range.

The easiest way to find the corresponding dart version is to checkout the Flutter version and run doctor:

$ git checkout 3.1.0
$ flutter doctor -v
...
[✓] Flutter (Channel unknown, 3.1.0, on macOS 13.2.1 22D68 darwin-x64, locale en-US)
...
    • Dart version 2.18.0 (build 2.18.0-44.1.beta)

Also, looks like the sdk version is now dynamic so I did not change it:

This is why I too haven't done this yet. 🙂

On master on a new plugin the constraint is:

environment:
  sdk: '>=3.0.0-322.0.dev <4.0.0'
  flutter: ">=2.5.0"

I think we should hold off on this for now until we know what the plan is to increase these versions. Fortunately this isn't that urgent, if plugin authors want to adjust these constraints manually, they can, but worst case they keep supporting older versions of Flutter, which isn't a bad thing.

jmagman · 2023-03-15T18:15:10Z

So this is be blocked on #118837, which is actively being worked on #122546
You can either close and wait for all that to settle and re-open, or you can convert this to a draft until that's done.

jmagman · 2023-03-15T18:47:57Z

See also #122739

stuartmorgan-g · 2023-03-15T18:54:18Z

I think just changing the (comically old) 2.5 to 3.3 is fine here, rather than blocking this. I don't see any downside to doing so while we figure out a longer term plan; it's not worse, and it won't make the long-term change any harder.

jmagman · 2023-03-15T19:00:37Z

I think just changing the (comically old) 2.5 to 3.3 is fine here

(here):

flutter/packages/flutter_tools/templates/plugin_shared/pubspec.yaml.tmpl

Line 9 in ffed0d5

flutter: ">=2.5.0"

Should we skip to 3.3? We only need 3.1 for this change.

stuartmorgan-g · 2023-03-15T19:06:03Z

I would do 3.3 rather than 3.1, since 3.3 is the oldest stable with what we need. Hard-coding an old beta version seems weird.

jmagman · 2023-03-15T19:10:46Z

I would do 3.3 rather than 3.1, since 3.3 is the oldest stable with what we need. Hard-coding an old beta version seems weird.

Oh you're right, I forgot 3.1 was just a stable candidate. That versioning is confusing...

jmagman · 2023-03-15T19:12:28Z

Okay @vashworth I stand corrected, if you update the plugin template to ~~flutter: '>=3.1.0'~~ flutter: '>=3.3.0' then this isn't blocked! Thanks @stuartmorgan for jumping in with context.

vashworth · 2023-03-15T19:21:07Z

@jmagman Do you mean 3.3?

I would do 3.3 rather than 3.1, since 3.3 is the oldest stable

Oh you're right, I forgot 3.1 was just a stable candidate. That versioning is confusing...

It's currently 3.3.0, should I change it to 3.3?

jmagman · 2023-03-15T21:11:43Z

@jmagman Do you mean 3.3?

Yes.

It's currently 3.3.0, should I change it to 3.3?

The spot we're talking about is 2.5

flutter/packages/flutter_tools/templates/plugin_shared/pubspec.yaml.tmpl

Line 9 in 5e54139

flutter: ">=2.5.0"

Where do you see 3.3.0?

vashworth · 2023-03-16T15:13:10Z

Where do you see 3.3.0?

Sorry, I meant it's already been changed to 3.3.0 in this PR

stuartmorgan-g

LGTM conceptually, just one code cleanup note.

stuartmorgan-g · 2023-03-16T17:32:54Z

packages/flutter_tools/templates/plugin_shared/pubspec.yaml.tmpl

+  flutter: ">=3.3.0"
 {{/withPlatformChannelPluginHook}}
 {{#withFfiPluginHook}}
  flutter: ">={{minFrameworkVersionFfiPlugin}}"


This is 2.11, so the branching for flutter: here, and minFrameworkVersionFfiPlugin in all of the code, can be eliminated now. It only existed because the platform channel version was lower than the FFI version, which is no longer the case.

jmagman

Can you also remove this dead @available(iOS 10, *) fallback:

flutter/packages/integration_test/ios/Classes/IntegrationTestPlugin.m

Line 98 in 4e4787a

    
           UIGraphicsBeginImageContextWithOptions(screenshotBounds.size, NO, UIScreen.mainScreen.scale);

jmagman

LGTM, thanks for the additional cleanup!

stuartmorgan-g

LGTM!

…ter#122625)

Fixes #140474 See #122625 where this was done 11->12.

update plugin podspec template to use ios 11

2105621

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 14, 2023

vashworth added 2 commits March 14, 2023 15:17

update integration_test and devicelab test

aca6a1f

fix test

704b14e

flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 14, 2023

vashworth requested a review from jmagman March 14, 2023 22:52

jmagman reviewed Mar 14, 2023

View reviewed changes

set plugin template min flutter version to 3.3.0

2e7d882

vashworth marked this pull request as draft March 15, 2023 18:15

vashworth marked this pull request as ready for review March 15, 2023 19:21

jmagman requested a review from stuartmorgan-g March 16, 2023 17:25

stuartmorgan-g requested changes Mar 16, 2023

View reviewed changes

jmagman reviewed Mar 16, 2023

View reviewed changes

vashworth added 2 commits March 17, 2023 10:53

remove usage of minFrameworkVersionFfiPlugin and dead iOS version check

8cdec2e

remove unused import

3e7a175

Merge branch 'master' into plugin_template_ios_default_os

857c0ce

jmagman approved these changes Mar 17, 2023

View reviewed changes

vashworth requested a review from stuartmorgan-g March 17, 2023 19:24

stuartmorgan-g approved these changes Mar 21, 2023

View reviewed changes

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023

auto-submit bot merged commit 9136a47 into flutter:master Mar 21, 2023

engine-flutter-autoroll mentioned this pull request Mar 22, 2023

Roll Flutter from 1ba3f99bb0aa to 520cf363b355 (27 revisions) flutter/packages#3514

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023

9136a47 Set plugin template minimum iOS version to 11.0 (flutter/flut…

d9dd09d

…ter#122625)

engine-flutter-autoroll mentioned this pull request Mar 22, 2023

Roll Flutter from 1ba3f99bb0aa to 02599119f2bf (29 revisions) flutter/packages#3516

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023

9136a47 Set plugin template minimum iOS version to 11.0 (flutter/flut…

aa32e42

…ter#122625)

engine-flutter-autoroll mentioned this pull request Mar 22, 2023

Roll Flutter from 1ba3f99bb0aa to 3f87e808f86b (30 revisions) flutter/packages#3517

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023

9136a47 Set plugin template minimum iOS version to 11.0 (flutter/flut…

a440a7d

…ter#122625)

engine-flutter-autoroll mentioned this pull request Mar 22, 2023

Roll Flutter from 1ba3f99bb0aa to b42e8db6cf8f (31 revisions) flutter/packages#3519

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023

9136a47 Set plugin template minimum iOS version to 11.0 (flutter/flut…

aeea755

…ter#122625)

engine-flutter-autoroll mentioned this pull request Mar 22, 2023

Roll Flutter from 1ba3f99bb0aa to 98a305501028 (33 revisions) flutter/packages#3520

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023

9136a47 Set plugin template minimum iOS version to 11.0 (flutter/flut…

9aacda6

…ter#122625)

engine-flutter-autoroll mentioned this pull request Mar 22, 2023

Manual roll Flutter from 1ba3f99bb0aa to f68a676353ed (37 revisions) flutter/packages#3522

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023

9136a47 Set plugin template minimum iOS version to 11.0 (flutter/flut…

c37d880

…ter#122625)

engine-flutter-autoroll mentioned this pull request Mar 23, 2023

Roll Flutter from 1ba3f99bb0aa to 250a6c294264 (46 revisions) flutter/packages#3528

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023

9136a47 Set plugin template minimum iOS version to 11.0 (flutter/flut…

c181eb3

…ter#122625)

engine-flutter-autoroll mentioned this pull request Mar 23, 2023

Roll Flutter from 1ba3f99bb0aa to 250a6c294264 (46 revisions) flutter/packages#3530

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023

9136a47 Set plugin template minimum iOS version to 11.0 (flutter/flut…

2f8c573

…ter#122625)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023

9136a47 Set plugin template minimum iOS version to 11.0 (flutter/flut…

66a994a

…ter#122625)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023

9136a47 Set plugin template minimum iOS version to 11.0 (flutter/flut…

7a7277d

…ter#122625)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

9136a47 Set plugin template minimum iOS version to 11.0 (flutter/flut…

7e5bc1e

…ter#122625)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

9136a47 Set plugin template minimum iOS version to 11.0 (flutter/flut…

c2c1c27

…ter#122625)

vashworth deleted the plugin_template_ios_default_os branch September 27, 2023 15:36

vashworth restored the plugin_template_ios_default_os branch September 27, 2023 15:36

jmagman mentioned this pull request Feb 8, 2024

Set plugin template minimum iOS version to 12.0 #143167

Merged

8 tasks

auto-submit bot pushed a commit that referenced this pull request Feb 9, 2024

Set plugin template minimum iOS version to 12.0 (#143167)

2fc1961

Fixes #140474 See #122625 where this was done 11->12.

Set plugin template minimum iOS version to 11.0 #122625

Set plugin template minimum iOS version to 11.0 #122625

Uh oh!

Conversation

vashworth commented Mar 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

vashworth commented Mar 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmagman left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vashworth commented Mar 15, 2023

Uh oh!

jmagman commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmagman commented Mar 15, 2023

Uh oh!

jmagman commented Mar 15, 2023

Uh oh!

stuartmorgan-g commented Mar 15, 2023

Uh oh!

jmagman commented Mar 15, 2023

Uh oh!

stuartmorgan-g commented Mar 15, 2023

Uh oh!

jmagman commented Mar 15, 2023

Uh oh!

jmagman commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vashworth commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmagman commented Mar 15, 2023

Uh oh!

vashworth commented Mar 16, 2023

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Mar 16, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vashworth commented Mar 14, 2023 •

edited

Loading

vashworth commented Mar 14, 2023 •

edited

Loading

jmagman left a comment •

edited

Loading

jmagman commented Mar 15, 2023 •

edited

Loading

jmagman commented Mar 15, 2023 •

edited

Loading

vashworth commented Mar 15, 2023 •

edited

Loading