Run Skia gold framework tests on arm64 Mac builders #122618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Piinks is there another issue this can close? #119880 (comment) |
Contributor
Not that I am aware of / can find. :) |
yusuf-goog
approved these changes
Mar 14, 2023
jmagman
added
the
autosubmit
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
#122639) Revert "Run Skia gold framework tests on arm64 Mac builders"
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
auto-submit bot
pushed a commit
that referenced
this pull request
May 19, 2023
The slowness issue was resolved with latest xcode: #119750, and all these targets should resume on both platforms as before. This will help mitigate high queue time on intel bots. This PR updates these targets: - Mac plugin_test_ios: #119764 - Mac build_tests: #120620 - Mac plugin_test: #120714 - Mac plugin_test_macos: #122212 - Mac framework_tests_misc: #122618
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
The slowness issue was resolved with latest xcode: flutter#119750, and all these targets should resume on both platforms as before. This will help mitigate high queue time on intel bots. This PR updates these targets: - Mac plugin_test_ios: flutter#119764 - Mac build_tests: flutter#120620 - Mac plugin_test: flutter#120714 - Mac plugin_test_macos: flutter#122212 - Mac framework_tests_misc: flutter#122618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Skia gold tests are now passing on arm64 Mac builders:
https://ci.chromium.org/p/flutter/builders/try/Mac%20framework_tests_libraries/34472
https://ci.chromium.org/p/flutter/builders/try/Mac%20framework_tests_widgets/36676
Keep
Mac framework_tests_miscon Intel due to #119750.I'm not sure exactly what made this start working, though...
Fixes #119880
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.