[web] stop using deprecated jsonwire web-driver protocol #122560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: tests
Contributor
|
Changes to .ci.yaml file LGTM |
ditman
reviewed
Mar 14, 2023
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
'chromeOptions' needs to be 'goog:chromeOptions' for tests to run. Otherwise there's an exception when creating the driver (?)
InvalidArgumentException (400): invalid argument: unrecognized capability: chromeOptions
#0 parseW3cResponse (package:webdriver/src/handler/w3c/utils.dart:42:9)
#1 W3cSessionHandler.parseCreateResponse (package:webdriver/src/handler/w3c/session.dart:19:21)
#2 InferSessionHandler.parseCreateResponse (package:webdriver/src/handler/infer_handler.dart:106:34)
#3 AsyncRequestClient.send (package:webdriver/src/common/request_client.dart:96:32)
<asynchronous suspension>
#4 createDriver (package:webdriver/async_core.dart:62:19)
<asynchronous suspension>
packages/flutter_tools/test/general.shard/drive/web_driver_service_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/general.shard/drive/web_driver_service_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/general.shard/drive/web_driver_service_test.dart
Outdated
Show resolved
Hide resolved
ditman
approved these changes
Mar 14, 2023
Member
There was a problem hiding this comment.
I ran the integration tests in the flutter/packages repository with this change, and everything seems to be passing (at least on Chrome 111):
$ ./script/tool_runner.sh drive-examples --web --exclude=google_sign_in,script/configs/exclude_integration_web.yaml
[... A ton of output ...]
------------------------------------------------------------
Run overview:
packages/camera/camera - ran
packages/camera/camera_web - ran
packages/google_identity_services_web - ran
packages/google_maps_flutter/google_maps_flutter_web - ran
packages/image_picker/image_picker - ran
packages/image_picker/image_picker_for_web - ran
packages/pointer_interceptor - ran
packages/shared_preferences/shared_preferences - ran
packages/shared_preferences/shared_preferences_web - ran
packages/url_launcher/url_launcher - ran
packages/url_launcher/url_launcher_web - ran
packages/video_player/video_player - ran
packages/video_player/video_player_web - ran
packages/webview_flutter/webview_flutter_web - ran
Ran for 14 package(s)
Skipped 88 package(s)
No issues found!
(PS: Skipped google_sign_in because I have changes in flight)
Contributor
Author
|
@ditman Thank you for kicking the tires for this change. Looks like there are good signals that this can stick, so I'm landing it. |
yjbanov
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using the deprecated jsonwire web-driver protocol. Use the W3C protocol instead.