Skip to content

Update tokens to v170 and fix mismatch between template and widget defaults #122548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
QuncCccccc wants to merge 1 commit into from
Closed

Update tokens to v170 and fix mismatch between template and widget defaults #122548

QuncCccccc wants to merge 1 commit into from

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Mar 13, 2023 •
edited
Loading

This PR is to update tokens to v170 and fix the mismatch between widget templates and widget defaults by running dart dev/tools/gen_defaults/bin/gen_defaults.dart.

The updated tokens are using new color scheme properties, such as surfaceContainerLow. So seems like we need to firstly add these properties to ColorScheme to unblock this PR.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 13, 2023
@QuncCccccc QuncCccccc mentioned this pull request Mar 13, 2023
Merged
8 tasks
@guidezpl
Copy link
Member

guidezpl commented Mar 13, 2023 •
edited
Loading

So, the updates above 162 represent a breaking change corresponding to #115912, that will need to be carefully prepared. See http://g/material-tokens-announce for more info.

Therefore, the fix from #121406 (review) has to be separated.

@QuncCccccc
Copy link
Contributor Author

QuncCccccc commented Mar 13, 2023

So, the updates above 162 represent a breaking change corresponding to #115912, that will need to be carefully prepared. See http://g/material-tokens-announce for more info.

Therefore, the fix from #121406 (review) has to be separated.

I see. Just created another small PR to include the fix: #122557 Thanks:)!

@QuncCccccc QuncCccccc closed this Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuncCccccc @guidezpl