Revert "Reland "Speed up first asset load by using the binary-formatted asset manifest for image resolution" #122449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
jonahwilliams
added
the
autosubmit
bdero
approved these changes
Mar 11, 2023
auto-submit
bot
deleted the
revert-121322-reland-use-binary-asset-manifest-for-asset-resolution
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2023
…-formatted asset manifest for image resolution (#121322)" (flutter/flutter#122449)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2023
…-formatted asset manifest for image resolution (#121322)" (flutter/flutter#122449)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
…-formatted asset manifest for image resolution (#121322)" (flutter/flutter#122449)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
…-formatted asset manifest for image resolution (#121322)" (flutter/flutter#122449)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #121322
I bisected the regression in the issue listed below to this commit. Perhaps there is an issue with the asset variants in the wonderous app? Not sure, if it was just a formatting issue I would expect them to load the default, or error out. but right now they are flashing which is definitely unexpected.
Fixes #122447