Skip to content

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Mar 10, 2023

Part of the 2D scrolling proposal: flutter.dev/go/2D-Foundation

Companion to #122357

Fixes #122355

For the relocated classes in #122357, this relocates the associated tests that were in scrollable_test.dart. The test files for scrollable are already a bit spread out (see test/scrollable_*), so only the one that were in scrollable_test.dart were moved.
These are the classes moved in the other PR:

  • ScrollableDetails
  • EdgeDraggingAutoScroller
    • These tests live elsewhere - scrollable_selection_test.dart
  • ScrollIncrementCalculator
    • tests moved in this PR
  • ScrollIncrementType
    • tests moved in this PR
  • ScrollIncrementDetails
    • tests moved in this PR
  • ScrollIncrementIntent
    • tests moved in this PR
  • ScrollAction
    • tests moved in this PR

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. c: tech-debt Technical debt, code quality, testing, etc. labels Mar 10, 2023
@Piinks Piinks requested a review from reidbaker March 10, 2023 21:22
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2023
@auto-submit auto-submit bot merged commit 53a1823 into flutter:master Mar 13, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up scrollable.dart to make way for 2D

2 participants