Reland (3): Removes single window assumptions from flutter_test
#122422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: tests
* Adds `TestFlutterView` to wrap `FlutterView` and allow modification of properties for testing * Updates `TestPlatformDispatcher` to wrap its views in `TestFlutterView`s when they are changed * Adds `viewOf` to `WidgetController` for finding a `TestFlutterView` related to the results of a `Finder` * Exposes `platformDispatcher` and `view` from `WidgetController` (and `WidgetTester`) * This is so the related `viewOf` method, which uses the `Finder` API, will be in a consistent place with these methods and other `Finder` APIs
pdblasi-google
force-pushed
the
issues/117481
branch
from
9f9566c to
6e0fead
Compare
goderbauer
approved these changes
Mar 13, 2023
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM
But do not land before attaching the g3fix to this. :)
Contributor
Author
|
G3fix scheduled, and internally the test run is green. Holding off on |
Contributor
Author
|
The |
pdblasi-google
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2023
This was referenced Mar 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestFlutterViewto wrapFlutterViewand allow modification of properties for testingTestPlatformDispatcherto wrap its views inTestFlutterViews when they are changedviewOftoWidgetControllerfor finding aTestFlutterViewrelated to the results of aFinderplatformDispatcherandviewfromWidgetController(andWidgetTester)viewOfmethod, which uses theFinderAPI, will be in a consistent place with these methods and otherFinderAPIsThere are no differences between this and the previous PR. Updates to google tests will be made to acommodate this change.
Resolves #117481.
Pre-launch Checklist
///).