Skip to content

Conversation

@goderbauer
Copy link
Member

Relands #122352.
Partial revert of #122369.

This change was functionally unrelated to the trouble solved by the revert in #122369.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 10, 2023
Copy link
Contributor

@pdblasi-google pdblasi-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers
Copy link
Contributor

Please do not submit until Google Testing is green, or an exemption is given.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2023
@goderbauer
Copy link
Member Author

Please do not submit until Google Testing is green, or an exemption is given.

The autosubmit bot is enforcing this, no?

@CaseyHillers
Copy link
Contributor

The autosubmit bot is enforcing this, no?

Autosubmit will, if present. However, Google Testing can take 90 minutes to show up on GitHub.

@auto-submit auto-submit bot merged commit b4019f9 into flutter:master Mar 10, 2023
@goderbauer goderbauer deleted the reland2 branch March 10, 2023 19:31
hannah-hyj pushed a commit to hannah-hyj/flutter that referenced this pull request Mar 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants