Skip to content

Refactor icon update script #122392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guidezpl merged 2 commits into from
Mar 13, 2023
Merged

Refactor icon update script #122392

guidezpl merged 2 commits into from
Mar 13, 2023

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented Mar 10, 2023 •
edited
Loading

  • Added an option --style-suffixes to be able to specify custom style suffixes
  • Renamed some variables to clarify what they do
  • Fix a link
  • Add a bit of documentation

Enables b/269131567

Verified that dart dev/tools/update_icons.dart --new-codepoints bin/cache/artifacts/material_fonts/codepoints produces the same file.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 10, 2023
@guidezpl guidezpl requested a review from xster March 10, 2023 12:03
@guidezpl guidezpl merged commit d8f7c3d into flutter:master Mar 13, 2023
@guidezpl guidezpl deleted the update-icons branch March 13, 2023 21:17
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2023
@engine-flutter-autoroll
d8f7c3d Refactor icon update script (flutter/flutter#122392)
64f22dc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2023
@engine-flutter-autoroll
d8f7c3d Refactor icon update script (flutter/flutter#122392)
5052fb1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d8f7c3d Refactor icon update script (flutter/flutter#122392)
10705ef
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
d8f7c3d Refactor icon update script (flutter/flutter#122392)
6fe80ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xster xster xster approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guidezpl @xster