Skip to content

Update Material tokens to 0.162 #122388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Mar 13, 2023
Merged

Update Material tokens to 0.162 #122388

auto-submit merged 5 commits into from
Mar 13, 2023

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented Mar 10, 2023

Also add secondary tab tokens.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@guidezpl guidezpl requested a review from QuncCccccc March 10, 2023 10:12
@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 10, 2023
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 10, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

QuncCccccc
QuncCccccc approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I noticed when I updated token last time, I included the new token sets for search bar and search view, but didn't create a CL to update the third-party token_files.py. I can create a CL to update search bar and view next week!

packages/flutter/lib/src/material/bottom_app_bar.dart
// dev/tools/gen_defaults/bin/gen_defaults.dart.

// Token database version: v0_158
// Token database version: v0_162
Copy link
Contributor

@QuncCccccc QuncCccccc Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ran the dart dev/tools/gen_defaults/bin/gen_defaults.dart to generate code, the shadowColor below becomes to Color? get shadowColor => Colors.transparent; because in its template, the type is Color? instead of Color. Just wonder why the shadowColor type is still Color but only the version number is updated here?

Copy link
Member Author

@guidezpl guidezpl Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, maybe you need to update from master?

Copy link
Contributor

@QuncCccccc QuncCccccc Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still can see the mismatch after syncing with master. Will fix it in my next token update PR!

Copy link
Member Author

@guidezpl guidezpl Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@guidezpl guidezpl added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2023
@auto-submit auto-submit bot merged commit 598ebfb into master Mar 13, 2023
@auto-submit auto-submit bot deleted the tokens branch March 13, 2023 16:16
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2023
@engine-flutter-autoroll
598ebfb Update Material tokens to 0.162 (flutter/flutter#122388)
e7e9d9c
@QuncCccccc QuncCccccc mentioned this pull request Mar 13, 2023
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2023
@engine-flutter-autoroll
598ebfb Update Material tokens to 0.162 (flutter/flutter#122388)
6798fd6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2023
@engine-flutter-autoroll
598ebfb Update Material tokens to 0.162 (flutter/flutter#122388)
aaaf762
@HansMuller HansMuller mentioned this pull request Mar 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
598ebfb Update Material tokens to 0.162 (flutter/flutter#122388)
2622a5b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
598ebfb Update Material tokens to 0.162 (flutter/flutter#122388)
b8a67c7
@QuncCccccc QuncCccccc mentioned this pull request Aug 13, 2024
Merged
9 tasks
auto-submit bot pushed a commit that referenced this pull request Aug 14, 2024
@QuncCccccc
Update tokens to 5.0.0 (#153385)
108a355 
This PR is to
* Update the Material Design tokens to 5.0.0
* 4 color roles in **Light mode** have different default values
   `onPrimaryContainer`: Primary10  -> Primary30 
   `onSecondaryContainer`: Secondary10 -> Secondary30
   `onTertiaryContainer`: Tertiary10 -> Tertiary30
   `onErrorContainer`: Error10 -> Error30
    
        ![Screenshot 2024-08-13 at 12 53 03â�¯PM](https://github.com/user-attachments/assets/bfa863d9-03d3-4557-8676-d56febdb2be5)

* new tokens added in list.json
* `md.comp.menu.list-item.*` tokens are deprecated and should be replaced by tokens in list.json and we've done the migration last year:)!(#122388)
DBowen33 pushed a commit to DBowen33/flutter that referenced this pull request Aug 16, 2024
@QuncCccccc @DBowen33
Update tokens to 5.0.0 (flutter#153385)
07e694c 
This PR is to
* Update the Material Design tokens to 5.0.0
* 4 color roles in **Light mode** have different default values
   `onPrimaryContainer`: Primary10  -> Primary30 
   `onSecondaryContainer`: Secondary10 -> Secondary30
   `onTertiaryContainer`: Tertiary10 -> Tertiary30
   `onErrorContainer`: Error10 -> Error30
    
        ![Screenshot 2024-08-13 at 12 53 03â�¯PM](https://github.com/user-attachments/assets/bfa863d9-03d3-4557-8676-d56febdb2be5)

* new tokens added in list.json
* `md.comp.menu.list-item.*` tokens are deprecated and should be replaced by tokens in list.json and we've done the migration last year:)!(flutter#122388)
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@QuncCccccc @Buchimi
Update tokens to 5.0.0 (flutter#153385)
51989c9 
This PR is to
* Update the Material Design tokens to 5.0.0
* 4 color roles in **Light mode** have different default values
   `onPrimaryContainer`: Primary10  -> Primary30 
   `onSecondaryContainer`: Secondary10 -> Secondary30
   `onTertiaryContainer`: Tertiary10 -> Tertiary30
   `onErrorContainer`: Error10 -> Error30
    
        ![Screenshot 2024-08-13 at 12 53 03â�¯PM](https://github.com/user-attachments/assets/bfa863d9-03d3-4557-8676-d56febdb2be5)

* new tokens added in list.json
* `md.comp.menu.list-item.*` tokens are deprecated and should be replaced by tokens in list.json and we've done the migration last year:)!(flutter#122388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guidezpl @QuncCccccc