[ios] fix hold and drag spacebar does not move cursor when obscureTex… #122383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: text input
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Member
|
(triage) @justinmc @LongCatIsLooong Could one of you take a look at this one? |
justinmc
approved these changes
Apr 25, 2023
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM with a small nit about indentation. Thanks for fixing this!
Also just for anyone looking at this PR in the future, the long term plan (as discussed on the engine PR) is to sync all of the TextInputConfiguration with the engine. This is just a stopgap for obscureText specifically.
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Apr 25, 2023
…t is true. (#40216) Fixes [flutter/flutter#122139](flutter/flutter#122139) with flutter pr [flutter/flutter#122383](flutter/flutter#122383)
cyanglaz
approved these changes
Apr 25, 2023
Contributor
cyanglaz
left a comment
cyanglaz
left a comment
There was a problem hiding this comment.
LGTM. The tests are failing tho, could you rebase and let the ci run again?
Member
Author
Contributor
|
Fixed! Sorry, it ended up with my personal email. |
Member
Author
|
@cyanglaz Hi, |
Contributor
|
cc @Renzo-Olivares from triage, run tests locally. |
Co-authored-by: Justin McCandless <[email protected]>
Renzo-Olivares
added
the
autosubmit
Contributor
|
Tests pass locally so I set the testing status to passed manually. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 8, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 8, 2023
flutter/flutter@43ac23b...4ed1c92 2023-05-08 [email protected] Roll Flutter Engine from c42dd23e29f6 to a8e9ac63fd95 (1 revision) (flutter/flutter#126265) 2023-05-08 [email protected] Clearer text about what happens with `--disable-telemetry` + enable-telemetry command (flutter/flutter#125995) 2023-05-08 [email protected] Roll Flutter Engine from 23f730efbff7 to c42dd23e29f6 (13 revisions) (flutter/flutter#126262) 2023-05-08 [email protected] Fix leaks (flutter/flutter#126144) 2023-05-08 [email protected] Update packages (flutter/flutter#126140) 2023-05-06 [email protected] [ExpansionPanelList] add materialGapSize property in ExpansionPanelList Widget (flutter/flutter#123971) 2023-05-06 [email protected] Roll Flutter Engine from eedcee66a710 to 23f730efbff7 (1 revision) (flutter/flutter#126199) 2023-05-06 [email protected] Roll Flutter Engine from 393b5649e7b4 to eedcee66a710 (1 revision) (flutter/flutter#126198) 2023-05-06 [email protected] Roll Flutter Engine from 876968833e46 to 393b5649e7b4 (1 revision) (flutter/flutter#126195) 2023-05-06 [email protected] [ios] fix hold and drag spacebar does not move cursor when obscureTex� (flutter/flutter#122383) 2023-05-06 [email protected] Roll Flutter Engine from d9116d94a111 to 876968833e46 (1 revision) (flutter/flutter#126192) 2023-05-06 [email protected] Roll Flutter Engine from 332f53219c4c to d9116d94a111 (1 revision) (flutter/flutter#126190) 2023-05-06 [email protected] Roll Flutter Engine from b7c79b41b9d4 to 332f53219c4c (3 revisions) (flutter/flutter#126188) 2023-05-06 [email protected] � Add `rect` argument to `_ArcPaintPredicate` for tests (flutter/flutter#125953) 2023-05-06 [email protected] Roll Flutter Engine from 758cbadfac1f to b7c79b41b9d4 (4 revisions) (flutter/flutter#126187) 2023-05-06 [email protected] Add Windows and Linux support to the 'layers' example (flutter/flutter#126105) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
flutter/flutter@43ac23b...4ed1c92 2023-05-08 [email protected] Roll Flutter Engine from c42dd23e29f6 to a8e9ac63fd95 (1 revision) (flutter/flutter#126265) 2023-05-08 [email protected] Clearer text about what happens with `--disable-telemetry` + enable-telemetry command (flutter/flutter#125995) 2023-05-08 [email protected] Roll Flutter Engine from 23f730efbff7 to c42dd23e29f6 (13 revisions) (flutter/flutter#126262) 2023-05-08 [email protected] Fix leaks (flutter/flutter#126144) 2023-05-08 [email protected] Update packages (flutter/flutter#126140) 2023-05-06 [email protected] [ExpansionPanelList] add materialGapSize property in ExpansionPanelList Widget (flutter/flutter#123971) 2023-05-06 [email protected] Roll Flutter Engine from eedcee66a710 to 23f730efbff7 (1 revision) (flutter/flutter#126199) 2023-05-06 [email protected] Roll Flutter Engine from 393b5649e7b4 to eedcee66a710 (1 revision) (flutter/flutter#126198) 2023-05-06 [email protected] Roll Flutter Engine from 876968833e46 to 393b5649e7b4 (1 revision) (flutter/flutter#126195) 2023-05-06 [email protected] [ios] fix hold and drag spacebar does not move cursor when obscureTex� (flutter/flutter#122383) 2023-05-06 [email protected] Roll Flutter Engine from d9116d94a111 to 876968833e46 (1 revision) (flutter/flutter#126192) 2023-05-06 [email protected] Roll Flutter Engine from 332f53219c4c to d9116d94a111 (1 revision) (flutter/flutter#126190) 2023-05-06 [email protected] Roll Flutter Engine from b7c79b41b9d4 to 332f53219c4c (3 revisions) (flutter/flutter#126188) 2023-05-06 [email protected] � Add `rect` argument to `_ArcPaintPredicate` for tests (flutter/flutter#125953) 2023-05-06 [email protected] Roll Flutter Engine from 758cbadfac1f to b7c79b41b9d4 (4 revisions) (flutter/flutter#126187) 2023-05-06 [email protected] Add Windows and Linux support to the 'layers' example (flutter/flutter#126105) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122139 with engine pr flutter/engine#40216