Factor out flutter manifest logic #12237

szakarias · 2017-09-25T08:52:39Z

No description provided.

Hixie · 2017-09-25T18:22:15Z

tvolkert · 2017-09-25T18:30:17Z

packages/flutter_tools/lib/src/asset.dart

 import 'dart/package_map.dart';
 import 'devfs.dart';
 import 'globals.dart';
+import 'flutter_manifest.dart';


Travis is complaining about the order of this import

tvolkert · 2017-09-25T18:37:09Z

packages/flutter_tools/test/flutter_manifest_test.dart

+  fonts:
+    - family: foo
+      fonts:
+        - asset: a/bar


It seems weird to allow duplicate asset names - which one takes precedence when this happens?

They are not entirely duplicates as one has an associated weight. In general I think it could make sense in a setting with several different weights. You might want to use one asset for some weights and another asset for other weights.

tvolkert · 2017-09-25T18:40:48Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+  }
+}
+
+dynamic _loadFlutterManifest(String manifestPath) {


Make this return Future<dynamic> so that you can use readAsString()

tvolkert · 2017-09-25T18:43:55Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+  @override
+  String toString() => 'Font (family: $familyName, assets: $fontAssets)';
+
+  Map<String, dynamic> getDescriptor() {


Make this a descriptor property?

tvolkert · 2017-09-25T18:47:54Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+   for (FontAsset fontAsset in fontAssets) {
+     assets.add(fontAsset.getDescriptor());
+   }
+   return <String, dynamic>{'fonts': assets, 'family': familyName};


Maybe phrase like so - your call.

return <String, dynamic>{ 'family': familyName, 'fonts': fontAssets.map((FontAsset a) => a.getDescriptor()).toList(), };

Much better, thanks!

tvolkert · 2017-09-25T18:51:24Z

packages/flutter_tools/lib/src/flutter_manifest.dart

@@ -0,0 +1,174 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.


Nit: no curly braces for single-line if statements throughout this file.

tvolkert · 2017-09-25T18:52:54Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+
+  bool get usesMaterialDesign {
+    return _flutterDescriptor.containsKey('uses-material-design') &&
+        _flutterDescriptor['uses-material-design'];


Just return _flutterDescriptor['uses-material-design'] ?? false

tvolkert · 2017-09-25T18:53:49Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+    if (!_flutterDescriptor.containsKey('fonts')) {
+      return <Map<String, dynamic>>[];
+    }
+    return _flutterDescriptor['fonts'];


_flutterDescriptor['fonts'] ?? const <Map<String, dynamic>>[]

tvolkert · 2017-09-25T18:54:14Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+    if (!_flutterDescriptor.containsKey('assets')) {
+      return <String>[];
+    }
+    return _flutterDescriptor['assets'];


_flutterDescriptor['assets'] ?? const <String>[]

tvolkert · 2017-09-25T18:58:19Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+    return _fonts;
+  }
+
+  static Future<FlutterManifest> createManifestFromPath(String path) async {


Document that these will return null if the manifest was unable to be created because of an invalid format, missing file, etc.

mravn-google

First batch of comments; still reviewing.

mravn-google · 2017-09-26T06:35:39Z

packages/flutter_tools/lib/src/asset.dart


-  return parsedFonts;
+List<Map<String, dynamic>> _createFontsDescriptor(List<Font> fonts) {
+  final List<Map<String, dynamic>> json = <Map<String, dynamic>>[];


You might be able to shorten this to something like return fonts.map((Font font) => font.getDescriptor()).toList()

mravn-google · 2017-09-26T06:45:40Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+    if (!_flutterDescriptor.containsKey('fonts')) {
+      return <Font>[];
+    }
+    if (_fonts == null) {


[nit] Maybe separate font extraction from use of the _fonts cache:

List get fonts { _fonts ??= _extractFonts(); return _fonts; } List _extractFonts() { if (!_flutterDescriptor.containsKey('fonts') return const []; final List fonts = []; // fill fonts return fonts; }

mravn-google · 2017-09-26T06:50:00Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+    return _fonts;
+  }
+
+  static Future<FlutterManifest> createManifestFromPath(String path) async {


[nit] The Manifest part of the method name could be elided: FlutterManifest.createFromPath instead of FlutterManifest.createManifestFromPath.

Similarly for the other create methods below.

mravn-google · 2017-09-26T06:51:20Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+/// A wrapper around the `flutter` section in the  `pubspec.yaml` file.
+class FlutterManifest {
+  Map<String, dynamic> _descriptor;
+  Map<String, dynamic> _flutterDescriptor;


Please add comments describing which parts of the pubspec file these two fields represent.

mravn-google · 2017-09-26T06:55:03Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+    }
+    pubspec._descriptor = yamlDocument;
+    pubspec._flutterDescriptor =
+        pubspec._descriptor['flutter'] ?? <String, dynamic>{};


Keep on one line.

mravn-google · 2017-09-26T07:06:04Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+  FontAsset(this.asset, {this.weight, this.style});
+
+  @override
+  String toString() => 'FontAsset (asset: $asset, weight; $weight, style: $style )';


As for Font.toString

mravn-google · 2017-09-26T07:08:42Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+  }
+
+  @override
+  String toString() => 'Font (family: $familyName, assets: $fontAssets)';


I believe the idiom is => '$runtimeType(x: $_x, y: $_y)' with no space after the type name. Using $runtimeType you don't have to remember to update toString if you rename the type.

mravn-google · 2017-09-26T07:09:24Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+  final int weight;
+  final String style;
+
+  FontAsset(this.asset, {this.weight, this.style});


Constructor first, then fields.

mravn-google · 2017-09-26T07:10:34Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+  String toString() => 'FontAsset (asset: $asset, weight; $weight, style: $style )';
+
+  Map<String, dynamic> getDescriptor() {
+    final Map<String, dynamic> descriptor = <String,dynamic>{};


Add space between , and dynamic, second occurrence.

mravn-google · 2017-09-26T07:11:21Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+  final String schemaPath = fs.path.join(fs.path.absolute(Cache.flutterRoot),
+      'packages', 'flutter_tools', 'schema', 'pubspec_yaml.json');
+  final Schema schema =
+      await Schema.createSchemaFromUrl(fs.path.toUri(schemaPath).toString());


Two non-Flutteristic line breaks here.

mravn-google

LGTM 👍

mravn-google · 2017-09-26T07:17:48Z

packages/flutter_tools/test/flutter_manifest_test.dart

+
+void main() {
+  setUpAll(() {
+    Cache.flutterRoot = getFlutterRoot();


Is this necessary?

Yes, since Cache.flutterRoot is used in _validate.

mravn-google · 2017-09-26T07:21:05Z

packages/flutter_tools/test/flutter_manifest_test.dart

+      expect(flutterManifest.assets, isEmpty);
+    });
+
+    test('usesMaterialDesign flag is set', () async {


Prefixing the group name, the name of this test reads "FlutterManifest usesMaterialDesign flag is set". I'd rename the test to knows if material design is used or similar to get "FlutterManifest knows if material design is used".

mravn-google · 2017-09-26T07:22:50Z

packages/flutter_tools/test/flutter_manifest_test.dart

+      final FlutterManifest flutterManifest = await FlutterManifest.createManifestFromString(manifest);
+      expect(flutterManifest, isNotNull);
+      expect(flutterManifest.appName, 'test');
+      expect(flutterManifest.usesMaterialDesign, true);


Unit test gurus would frown on you for having too many expects in your test. This test is about the usesMaterialDesign flag, and should expect only that to ease test maintenance.

mravn-google · 2017-09-26T07:26:44Z

packages/flutter_tools/test/flutter_manifest_test.dart

+      final List<String> assets = flutterManifest.assets;
+      expect(assets.length, 2);
+      expect(assets, contains('a/foo'));
+      expect(assets, contains('a/bar'));


These are the expects relevant to this test. I believe they could be written

expect(flutterManifest.assets, <String>['a/foo', 'a/bar']);

mravn-google · 2017-09-26T07:29:26Z

packages/flutter_tools/test/flutter_manifest_test.dart

+      expect(barFontAsset1.style, 'italic');
+    });
+
+    testUsingContext('has only one of two font familes when one declaration is missing the "family" option', () async {


Can't we just use test here?
And below.

No, since these trigger code that needs a context. (Specifically it is the printError calls in _extractFonts)

szakarias

Thanks a lot for the comments!

szakarias · 2017-09-26T08:48:15Z

packages/flutter_tools/test/flutter_manifest_test.dart

+
+void main() {
+  setUpAll(() {
+    Cache.flutterRoot = getFlutterRoot();


Yes, since Cache.flutterRoot is used in _validate.

szakarias · 2017-09-26T08:48:43Z

packages/flutter_tools/lib/src/flutter_manifest.dart

+   for (FontAsset fontAsset in fontAssets) {
+     assets.add(fontAsset.getDescriptor());
+   }
+   return <String, dynamic>{'fonts': assets, 'family': familyName};


Much better, thanks!

szakarias · 2017-09-26T08:58:39Z

packages/flutter_tools/test/flutter_manifest_test.dart

+      expect(barFontAsset1.style, 'italic');
+    });
+
+    testUsingContext('has only one of two font familes when one declaration is missing the "family" option', () async {


No, since these trigger code that needs a context. (Specifically it is the printError calls in _extractFonts)

szakarias · 2017-09-26T10:38:11Z

packages/flutter_tools/test/flutter_manifest_test.dart

+  fonts:
+    - family: foo
+      fonts:
+        - asset: a/bar


They are not entirely duplicates as one has an associated weight. In general I think it could make sense in a setting with several different weights. You might want to use one asset for some weights and another asset for other weights.

mravn-google

LGTM

abarth · 2017-09-26T16:45:24Z

This change broke the Fuchsia build:

Error building /src/fuchsia/out/debug-x86-64/gen/garnet/examples/bluetooth/settings/settings.flx: 1
[374/630] ACTION //peridot/examples/story_shell_flutt...le_flutter_story_shell(//build/toolchain/fuchsia:x64)
FAILED: gen/peridot/examples/story_shell_flutter/example_flutter_story_shell.flx 
/usr/bin/env ../../flutter/build/package.py --flutter-root /src/fuchsia/lib/flutter --flutter-tools /src/fuchsia/out/debug-x86-64/host_x64/dart-tools/fuchsia_builder --working-dir /src/fuchsia/out/debug-x86-64/gen/peridot/examples/story_shell_flutter/example_flutter_story_shell/build --app-dir /src/fuchsia/peridot/examples/story_shell_flutter --packages /src/fuchsia/out/debug-x86-64/gen/peridot/examples/story_shell_flutter/example_flutter_story_shell_dart_package.packages --output-file /src/fuchsia/out/debug-x86-64/gen/peridot/examples/story_shell_flutter/example_flutter_story_shell.flx --snapshot /src/fuchsia/out/debug-x86-64/gen/peridot/examples/story_shell_flutter/example_flutter_story_shell_snapshot.bin --build-root /src/fuchsia/out/debug-x86-64 --depfile /src/fuchsia/out/debug-x86-64/gen/peridot/examples/story_shell_flutter/example_flutter_story_shell.flx.d --interpreter flutter_runner
Error building /src/fuchsia/out/debug-x86-64/gen/peridot/examples/story_shell_flutter/example_flutter_story_shell.flx: 1

abarth · 2017-09-26T16:48:41Z

To reproduce, follow the instructions on this page to build Fuchsia:

https://fuchsia.googlesource.com/docs/+/master/getting_started.md#setup-build-environment

I'm going to pin the revision of Flutter to prior to this change so that you don't have time pressure to fix this issue. To reproduce the issue, you'll need to cd lib/flutter && git checkout origin/master to get the master branch of Flutter into your Fuchsia working copy.

Once you've fixed the issue, please update the version of Flutter in https://fuchsia.googlesource.com/manifest/+/master/flutter (which will be in //manifest/flutter in your working copy). That file doesn't exist yet, but will exist soon. :)

szakarias · 2017-09-27T12:50:22Z

Thanks a lot. The issue was fixed in #12269.

I've uploaded a change, but I am not familiar with Gerrit so here is a link in case it hasn't been sent: https://fuchsia-review.googlesource.com/#/c/manifest/+/68365/

abarth · 2017-09-27T15:30:02Z

Thanks!

There are overlapping TODAY issues (#40303 and #40114) that prevent this roll from being split up further. git log 7ea9884..3c6383f --no-merges --oneline 3c6383f Revert "Smooth out iOS irregular input events delivery (#11817)" (#12251) d6f0b64 pin and auto-install chrome version (#12228) 2698a0e Roll fuchsia/sdk/core/mac-amd64 from Ne2UA... to JVZ_i... (#12250) dfa9498 Enable platform view keyboard input on Android Q (#12085) bf91a8d Roll fuchsia/sdk/core/linux-amd64 from u7Q31... to vuG5q... (#12238) 58ecf52 Roll src/third_party/skia 7c47d41067d4..be194479d27f (4 commits) (#12237) c71580b Roll dart to e6887536aadc7fbd1990448989601cee0224958d. (#12235) cf1d156 Roll fuchsia/sdk/core/mac-amd64 from _nS67... to Ne2UA... (#12236) bbb1f12 Adjust iOS frame start times to match the platform info (#11802) 1de28d0 Roll src/third_party/skia 50f377e275c3..7c47d41067d4 (3 commits) (#12231) da84d59 Revert "Manage iOS contexts separately (#12078)" (#12233) 4ac0663 Manage iOS contexts separately (#12078) 28d7900 Roll src/third_party/skia 120e7d6766e4..50f377e275c3 (7 commits) (#12224) 5b94c8a Revert "Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)" (#12223) 988efe3 Do not generate kernel platform files on topaz tree (#12222) 6c46a17 Don't disable toString in release mode for dart:ui classes (#12204) 80b8ed8 Roll fuchsia/sdk/core/linux-amd64 from 7gDBN... to u7Q31... (#12221) 7a8caaa Roll src/third_party/skia d96ef09317d6..120e7d6766e4 (2 commits) (#12220) c8428ff Roll fuchsia/sdk/core/mac-amd64 from vDk46... to _nS67... (#12219) 2bdfb61 Namespace patched SDK names to not conflict with Topaz (#12218) ff1fcfb Roll src/third_party/dart ca7baa4013..4d5e15abde (29 commits) 2b78c59 Roll src/third_party/skia 14318c140949..d96ef09317d6 (2 commits) (#12216) d74ed76 Roll src/third_party/skia b23a4f9d9442..14318c140949 (2 commits) (#12215) c58c593 Roll src/third_party/skia 26ac0467cb4c..b23a4f9d9442 (2 commits) (#12214) 5e85403 Roll src/third_party/dart 7bbfd532de..ca7baa4013 (3 commits) e2cc04c Roll fuchsia/sdk/core/linux-amd64 from R1yqu... to 7gDBN... (#12212) 6fbfb45 Roll fuchsia/sdk/core/mac-amd64 from spUG2... to vDk46... (#12210) 96443e2 Roll buildroot and Fuchsia toolchain and unblock the Fuchsia/Linux autoroller manually. (#12209) 34cf4f7 Roll src/third_party/skia 4fe30e15c06c..26ac0467cb4c (2 commits) (#12207) 92d42c0 Only build the x64 variant of Fuchsia on the try-jobs. (#12206) e174b4b Don't load Roboto by default (#12205) efb32a6 Roll src/third_party/dart 300c3333d1..7bbfd532de (5 commits) 5566be1 Roll src/third_party/skia 66d8006c2bb1..4fe30e15c06c (11 commits) (#12202) e9c9984 add a convenience CLI tool for building and testing web engine (#12197) bfa43e1 [flutter_runner] Generate symbols for the Dart VM profiler (#12048) 954f198 Add custom test plugin that supports screenshot tests (#12079) d8379f9 Move the Fuchsia tryjob into a its own step and disable LTO. (#12190) c12ac24 Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits) cab3a39 Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (#12178) 2592d6e [flutter_runner] Port the accessibility bridge from Topaz (#12054) b569e8c Smooth out iOS irregular input events delivery (#11817) dea813d Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits) 2438798 Make ImageShader implement Shader for web ui (#12161) c31583a Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits) 4542886 Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (#12151) 548998f Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (#12129) f1490a2 Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (#12106) 19b2d43 Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (#12088) d816755 Don't launch the observatory by default on each embedder unit-test invocation. (#12087) 39c8067 Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (#12086) b19e75a Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits) 03e773a Guard availability of user notification related methods to iOS 10.0 (#12084) 9c00c26 Add capability to add AppDelegate as UNUserNotificationCenterDelegate (#9864) c2e8289 Add GradientRadial paintStyle implementation (#12081) c3eea0a Don't quote generic font families (#12080) c2b3d88 Roll src/third_party/skia 28d40b2e7ade..c2d84bfa7421 (3 commits) (#12082) a4de006 Remove ENABLE_BITCODE from Scenarios test app (#11839) 6e017f0 Roll src/third_party/skia 4f2674da4bbc..28d40b2e7ade (4 commits) (#12077) e911b05 Roll src/third_party/skia 627d15588f4d..4f2674da4bbc (1 commits) (#12075) 359e663 Roll src/third_party/skia 6c3bd09ead0f..627d15588f4d (3 commits) (#12074) 38d545e Improve Unicode handling on Windows (#11899) 89efb4c Roll fuchsia/clang/linux-amd64 from VoYNW... to 2IT_b... (#12072) dc8e30d Roll fuchsia/clang/mac-amd64 from XAazI... to H1Qjc... (#12071) 8cdb3af Annotate nullability on FlutterEngine to make swift writing more ergonomic (#11808) aa9aaa2 Roll src/third_party/skia f433336585ed..6c3bd09ead0f (1 commits) (#12070) 075a61f Roll src/third_party/skia 69a426f5a427..f433336585ed (1 commits) (#12068) a610505 option for --no-lto for fuchsia (#12010) be39820 Roll src/third_party/skia 380561393385..69a426f5a427 (2 commits) (#12067) 6bafbf9 Roll src/third_party/skia c30f1a936d84..380561393385 (3 commits) (#12059) e2ba93d Roll src/third_party/dart ec7ec4ecf7..fb14babf59 (19 commits) 723a288 Roll fuchsia/clang/linux-amd64 from -mnHl... to VoYNW... (#12058) 35875e0 Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (#11798)" (#12055) a353f93 Manage resource and onscreen contexts using separate IOSGLContext objects (#11798) c9ea4db [flutter_runner] Refactor our build rules to make them more inline with topaz. (#12034) 50bdbd7 Document dependencies and remove support-v13 (#11912) 0c6a538 Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits) 37f81cd Roll src/third_party/skia 080d210e7acc..c30f1a936d84 (21 commits) (#12031)

Changes since last roll: ``` 6e6de94 Roll dart to d9489622befb638c040975163cf9b8eba2ff057b. (flutter#12255) 5c86111 [glfw/windows] Stops keeping track of input models (flutter#12234) 9c84659 Editable text fix (flutter#12249) cce4b5b Roll src/third_party/dart e6887536aa..c74e68e501 (14 commits) 55c346a Roll fuchsia/sdk/core/linux-amd64 from vuG5q... to 6a4X4... (flutter#12252) 6beba53 Started taking advantage of Skia's new copyTableData to avoid (flutter#10154) 3c6383f Revert "Smooth out iOS irregular input events delivery (flutter#11817)" (flutter#12251) d6f0b64 pin and auto-install chrome version (flutter#12228) 2698a0e Roll fuchsia/sdk/core/mac-amd64 from Ne2UA... to JVZ_i... (flutter#12250) dfa9498 Enable platform view keyboard input on Android Q (flutter#12085) bf91a8d Roll fuchsia/sdk/core/linux-amd64 from u7Q31... to vuG5q... (flutter#12238) 58ecf52 Roll src/third_party/skia 7c47d41067d4..be194479d27f (4 commits) (flutter#12237) c71580b Roll dart to e6887536aadc7fbd1990448989601cee0224958d. (flutter#12235) cf1d156 Roll fuchsia/sdk/core/mac-amd64 from _nS67... to Ne2UA... (flutter#12236) bbb1f12 Adjust iOS frame start times to match the platform info (flutter#11802) 1de28d0 Roll src/third_party/skia 50f377e275c3..7c47d41067d4 (3 commits) (flutter#12231) da84d59 Revert "Manage iOS contexts separately (flutter#12078)" (flutter#12233) 4ac0663 Manage iOS contexts separately (flutter#12078) 28d7900 Roll src/third_party/skia 120e7d6766e4..50f377e275c3 (7 commits) (flutter#12224) 5b94c8a Revert "Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)" (flutter#12223) 988efe3 Do not generate kernel platform files on topaz tree (flutter#12222) 6c46a17 Don't disable toString in release mode for dart:ui classes (flutter#12204) 80b8ed8 Roll fuchsia/sdk/core/linux-amd64 from 7gDBN... to u7Q31... (flutter#12221) 7a8caaa Roll src/third_party/skia d96ef09317d6..120e7d6766e4 (2 commits) (flutter#12220) c8428ff Roll fuchsia/sdk/core/mac-amd64 from vDk46... to _nS67... (flutter#12219) 2bdfb61 Namespace patched SDK names to not conflict with Topaz (flutter#12218) ff1fcfb Roll src/third_party/dart ca7baa4013..4d5e15abde (29 commits) 2b78c59 Roll src/third_party/skia 14318c140949..d96ef09317d6 (2 commits) (flutter#12216) d74ed76 Roll src/third_party/skia b23a4f9d9442..14318c140949 (2 commits) (flutter#12215) c58c593 Roll src/third_party/skia 26ac0467cb4c..b23a4f9d9442 (2 commits) (flutter#12214) 5e85403 Roll src/third_party/dart 7bbfd532de..ca7baa4013 (3 commits) e2cc04c Roll fuchsia/sdk/core/linux-amd64 from R1yqu... to 7gDBN... (flutter#12212) 6fbfb45 Roll fuchsia/sdk/core/mac-amd64 from spUG2... to vDk46... (flutter#12210) 96443e2 Roll buildroot and Fuchsia toolchain and unblock the Fuchsia/Linux autoroller manually. (flutter#12209) 34cf4f7 Roll src/third_party/skia 4fe30e15c06c..26ac0467cb4c (2 commits) (flutter#12207) 92d42c0 Only build the x64 variant of Fuchsia on the try-jobs. (flutter#12206) e174b4b Don't load Roboto by default (flutter#12205) efb32a6 Roll src/third_party/dart 300c3333d1..7bbfd532de (5 commits) 5566be1 Roll src/third_party/skia 66d8006c2bb1..4fe30e15c06c (11 commits) (flutter#12202) e9c9984 add a convenience CLI tool for building and testing web engine (flutter#12197) bfa43e1 [flutter_runner] Generate symbols for the Dart VM profiler (flutter#12048) 954f198 Add custom test plugin that supports screenshot tests (flutter#12079) d8379f9 Move the Fuchsia tryjob into a its own step and disable LTO. (flutter#12190) c12ac24 Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits) cab3a39 Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (flutter#12178) 2592d6e [flutter_runner] Port the accessibility bridge from Topaz (flutter#12054) b569e8c Smooth out iOS irregular input events delivery (flutter#11817) dea813d Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits) 2438798 Make ImageShader implement Shader for web ui (flutter#12161) c31583a Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits) 4542886 Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (flutter#12151) 548998f Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (flutter#12129) f1490a2 Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (flutter#12106) 19b2d43 Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (flutter#12088) d816755 Don't launch the observatory by default on each embedder unit-test invocation. (flutter#12087) 39c8067 Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (flutter#12086) b19e75a Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits) 03e773a Guard availability of user notification related methods to iOS 10.0 (flutter#12084) 9c00c26 Add capability to add AppDelegate as UNUserNotificationCenterDelegate (flutter#9864) c2e8289 Add GradientRadial paintStyle implementation (flutter#12081) c3eea0a Don't quote generic font families (flutter#12080) c2b3d88 Roll src/third_party/skia 28d40b2e7ade..c2d84bfa7421 (3 commits) (flutter#12082) a4de006 Remove ENABLE_BITCODE from Scenarios test app (flutter#11839) 6e017f0 Roll src/third_party/skia 4f2674da4bbc..28d40b2e7ade (4 commits) (flutter#12077) e911b05 Roll src/third_party/skia 627d15588f4d..4f2674da4bbc (1 commits) (flutter#12075) 359e663 Roll src/third_party/skia 6c3bd09ead0f..627d15588f4d (3 commits) (flutter#12074) 38d545e Improve Unicode handling on Windows (flutter#11899) 89efb4c Roll fuchsia/clang/linux-amd64 from VoYNW... to 2IT_b... (flutter#12072) dc8e30d Roll fuchsia/clang/mac-amd64 from XAazI... to H1Qjc... (flutter#12071) 8cdb3af Annotate nullability on FlutterEngine to make swift writing more ergonomic (flutter#11808) aa9aaa2 Roll src/third_party/skia f433336585ed..6c3bd09ead0f (1 commits) (flutter#12070) 075a61f Roll src/third_party/skia 69a426f5a427..f433336585ed (1 commits) (flutter#12068) a610505 option for --no-lto for fuchsia (flutter#12010) be39820 Roll src/third_party/skia 380561393385..69a426f5a427 (2 commits) (flutter#12067) 6bafbf9 Roll src/third_party/skia c30f1a936d84..380561393385 (3 commits) (flutter#12059) e2ba93d Roll src/third_party/dart ec7ec4ecf7..fb14babf59 (19 commits) 723a288 Roll fuchsia/clang/linux-amd64 from -mnHl... to VoYNW... (flutter#12058) 35875e0 Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (flutter#11798)" (flutter#12055) a353f93 Manage resource and onscreen contexts using separate IOSGLContext objects (flutter#11798) c9ea4db [flutter_runner] Refactor our build rules to make them more inline with topaz. (flutter#12034) 50bdbd7 Document dependencies and remove support-v13 (flutter#11912) 0c6a538 Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits) 37f81cd Roll src/third_party/skia 080d210e7acc..c30f1a936d84 (21 commits) (flutter#12031) ```

Changes since last roll: ``` 6e6de94 Roll dart to d9489622befb638c040975163cf9b8eba2ff057b. (#12255) 5c86111 [glfw/windows] Stops keeping track of input models (#12234) 9c84659 Editable text fix (#12249) cce4b5b Roll src/third_party/dart e6887536aa..c74e68e501 (14 commits) 55c346a Roll fuchsia/sdk/core/linux-amd64 from vuG5q... to 6a4X4... (#12252) 6beba53 Started taking advantage of Skia's new copyTableData to avoid (#10154) 3c6383f Revert "Smooth out iOS irregular input events delivery (#11817)" (#12251) d6f0b64 pin and auto-install chrome version (#12228) 2698a0e Roll fuchsia/sdk/core/mac-amd64 from Ne2UA... to JVZ_i... (#12250) dfa9498 Enable platform view keyboard input on Android Q (#12085) bf91a8d Roll fuchsia/sdk/core/linux-amd64 from u7Q31... to vuG5q... (#12238) 58ecf52 Roll src/third_party/skia 7c47d41067d4..be194479d27f (4 commits) (#12237) c71580b Roll dart to e6887536aadc7fbd1990448989601cee0224958d. (#12235) cf1d156 Roll fuchsia/sdk/core/mac-amd64 from _nS67... to Ne2UA... (#12236) bbb1f12 Adjust iOS frame start times to match the platform info (#11802) 1de28d0 Roll src/third_party/skia 50f377e275c3..7c47d41067d4 (3 commits) (#12231) da84d59 Revert "Manage iOS contexts separately (#12078)" (#12233) 4ac0663 Manage iOS contexts separately (#12078) 28d7900 Roll src/third_party/skia 120e7d6766e4..50f377e275c3 (7 commits) (#12224) 5b94c8a Revert "Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)" (#12223) 988efe3 Do not generate kernel platform files on topaz tree (#12222) 6c46a17 Don't disable toString in release mode for dart:ui classes (#12204) 80b8ed8 Roll fuchsia/sdk/core/linux-amd64 from 7gDBN... to u7Q31... (#12221) 7a8caaa Roll src/third_party/skia d96ef09317d6..120e7d6766e4 (2 commits) (#12220) c8428ff Roll fuchsia/sdk/core/mac-amd64 from vDk46... to _nS67... (#12219) 2bdfb61 Namespace patched SDK names to not conflict with Topaz (#12218) ff1fcfb Roll src/third_party/dart ca7baa4013..4d5e15abde (29 commits) 2b78c59 Roll src/third_party/skia 14318c140949..d96ef09317d6 (2 commits) (#12216) d74ed76 Roll src/third_party/skia b23a4f9d9442..14318c140949 (2 commits) (#12215) c58c593 Roll src/third_party/skia 26ac0467cb4c..b23a4f9d9442 (2 commits) (#12214) 5e85403 Roll src/third_party/dart 7bbfd532de..ca7baa4013 (3 commits) e2cc04c Roll fuchsia/sdk/core/linux-amd64 from R1yqu... to 7gDBN... (#12212) 6fbfb45 Roll fuchsia/sdk/core/mac-amd64 from spUG2... to vDk46... (#12210) 96443e2 Roll buildroot and Fuchsia toolchain and unblock the Fuchsia/Linux autoroller manually. (#12209) 34cf4f7 Roll src/third_party/skia 4fe30e15c06c..26ac0467cb4c (2 commits) (#12207) 92d42c0 Only build the x64 variant of Fuchsia on the try-jobs. (#12206) e174b4b Don't load Roboto by default (#12205) efb32a6 Roll src/third_party/dart 300c3333d1..7bbfd532de (5 commits) 5566be1 Roll src/third_party/skia 66d8006c2bb1..4fe30e15c06c (11 commits) (#12202) e9c9984 add a convenience CLI tool for building and testing web engine (#12197) bfa43e1 [flutter_runner] Generate symbols for the Dart VM profiler (#12048) 954f198 Add custom test plugin that supports screenshot tests (#12079) d8379f9 Move the Fuchsia tryjob into a its own step and disable LTO. (#12190) c12ac24 Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits) cab3a39 Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (#12178) 2592d6e [flutter_runner] Port the accessibility bridge from Topaz (#12054) b569e8c Smooth out iOS irregular input events delivery (#11817) dea813d Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits) 2438798 Make ImageShader implement Shader for web ui (#12161) c31583a Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits) 4542886 Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (#12151) 548998f Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (#12129) f1490a2 Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (#12106) 19b2d43 Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (#12088) d816755 Don't launch the observatory by default on each embedder unit-test invocation. (#12087) 39c8067 Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (#12086) b19e75a Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits) 03e773a Guard availability of user notification related methods to iOS 10.0 (#12084) 9c00c26 Add capability to add AppDelegate as UNUserNotificationCenterDelegate (#9864) c2e8289 Add GradientRadial paintStyle implementation (#12081) c3eea0a Don't quote generic font families (#12080) c2b3d88 Roll src/third_party/skia 28d40b2e7ade..c2d84bfa7421 (3 commits) (#12082) a4de006 Remove ENABLE_BITCODE from Scenarios test app (#11839) 6e017f0 Roll src/third_party/skia 4f2674da4bbc..28d40b2e7ade (4 commits) (#12077) e911b05 Roll src/third_party/skia 627d15588f4d..4f2674da4bbc (1 commits) (#12075) 359e663 Roll src/third_party/skia 6c3bd09ead0f..627d15588f4d (3 commits) (#12074) 38d545e Improve Unicode handling on Windows (#11899) 89efb4c Roll fuchsia/clang/linux-amd64 from VoYNW... to 2IT_b... (#12072) dc8e30d Roll fuchsia/clang/mac-amd64 from XAazI... to H1Qjc... (#12071) 8cdb3af Annotate nullability on FlutterEngine to make swift writing more ergonomic (#11808) aa9aaa2 Roll src/third_party/skia f433336585ed..6c3bd09ead0f (1 commits) (#12070) 075a61f Roll src/third_party/skia 69a426f5a427..f433336585ed (1 commits) (#12068) a610505 option for --no-lto for fuchsia (#12010) be39820 Roll src/third_party/skia 380561393385..69a426f5a427 (2 commits) (#12067) 6bafbf9 Roll src/third_party/skia c30f1a936d84..380561393385 (3 commits) (#12059) e2ba93d Roll src/third_party/dart ec7ec4ecf7..fb14babf59 (19 commits) 723a288 Roll fuchsia/clang/linux-amd64 from -mnHl... to VoYNW... (#12058) 35875e0 Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (#11798)" (#12055) a353f93 Manage resource and onscreen contexts using separate IOSGLContext objects (#11798) c9ea4db [flutter_runner] Refactor our build rules to make them more inline with topaz. (#12034) 50bdbd7 Document dependencies and remove support-v13 (#11912) 0c6a538 Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits) 37f81cd Roll src/third_party/skia 080d210e7acc..c30f1a936d84 (21 commits) (#12031) ```

1b63444 Revert "Started taking advantage of Skia's new copyTableData to avoid (#10154)" (#12263) 0897b50 Roll fuchsia/sdk/core/linux-amd64 from 6a4X4... to Xfeuz... (#12261) 186014c Roll src/third_party/skia be194479d27f..043dba039e0d (23 commits) (#12262) 4debdda Roll fuchsia/sdk/core/mac-amd64 from JVZ_i... to gVBCH... (#12260) 9e7bd05 Roll src/third_party/dart d9489622be..a554c8be6b (10 commits) 850d80c Revert "Add some AppLifecycleTests (#11890)" (#12264) 46ff053 Add some AppLifecycleTests (#11890) ca4c3f6 Add an initial macOS version of FlutterAppDelegate (#12230) 6e6de94 Roll dart to d9489622befb638c040975163cf9b8eba2ff057b. (#12255) 5c86111 [glfw/windows] Stops keeping track of input models (#12234) 9c84659 Editable text fix (#12249) cce4b5b Roll src/third_party/dart e6887536aa..c74e68e501 (14 commits) 55c346a Roll fuchsia/sdk/core/linux-amd64 from vuG5q... to 6a4X4... (#12252) 6beba53 Started taking advantage of Skia's new copyTableData to avoid (#10154) 3c6383f Revert "Smooth out iOS irregular input events delivery (#11817)" (#12251) d6f0b64 pin and auto-install chrome version (#12228) 2698a0e Roll fuchsia/sdk/core/mac-amd64 from Ne2UA... to JVZ_i... (#12250) dfa9498 Enable platform view keyboard input on Android Q (#12085) bf91a8d Roll fuchsia/sdk/core/linux-amd64 from u7Q31... to vuG5q... (#12238) 58ecf52 Roll src/third_party/skia 7c47d41067d4..be194479d27f (4 commits) (#12237) c71580b Roll dart to e6887536aadc7fbd1990448989601cee0224958d. (#12235) cf1d156 Roll fuchsia/sdk/core/mac-amd64 from _nS67... to Ne2UA... (#12236) bbb1f12 Adjust iOS frame start times to match the platform info (#11802) 1de28d0 Roll src/third_party/skia 50f377e275c3..7c47d41067d4 (3 commits) (#12231) da84d59 Revert "Manage iOS contexts separately (#12078)" (#12233) 4ac0663 Manage iOS contexts separately (#12078) 28d7900 Roll src/third_party/skia 120e7d6766e4..50f377e275c3 (7 commits) (#12224) 5b94c8a Revert "Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)" (#12223) 988efe3 Do not generate kernel platform files on topaz tree (#12222) 6c46a17 Don't disable toString in release mode for dart:ui classes (#12204) 80b8ed8 Roll fuchsia/sdk/core/linux-amd64 from 7gDBN... to u7Q31... (#12221) 7a8caaa Roll src/third_party/skia d96ef09317d6..120e7d6766e4 (2 commits) (#12220) c8428ff Roll fuchsia/sdk/core/mac-amd64 from vDk46... to _nS67... (#12219) 2bdfb61 Namespace patched SDK names to not conflict with Topaz (#12218) ff1fcfb Roll src/third_party/dart ca7baa4013..4d5e15abde (29 commits) 2b78c59 Roll src/third_party/skia 14318c140949..d96ef09317d6 (2 commits) (#12216) d74ed76 Roll src/third_party/skia b23a4f9d9442..14318c140949 (2 commits) (#12215) c58c593 Roll src/third_party/skia 26ac0467cb4c..b23a4f9d9442 (2 commits) (#12214) 5e85403 Roll src/third_party/dart 7bbfd532de..ca7baa4013 (3 commits) e2cc04c Roll fuchsia/sdk/core/linux-amd64 from R1yqu... to 7gDBN... (#12212) 6fbfb45 Roll fuchsia/sdk/core/mac-amd64 from spUG2... to vDk46... (#12210) 96443e2 Roll buildroot and Fuchsia toolchain and unblock the Fuchsia/Linux autoroller manually. (#12209) 34cf4f7 Roll src/third_party/skia 4fe30e15c06c..26ac0467cb4c (2 commits) (#12207) 92d42c0 Only build the x64 variant of Fuchsia on the try-jobs. (#12206) e174b4b Don't load Roboto by default (#12205) efb32a6 Roll src/third_party/dart 300c3333d1..7bbfd532de (5 commits) 5566be1 Roll src/third_party/skia 66d8006c2bb1..4fe30e15c06c (11 commits) (#12202) e9c9984 add a convenience CLI tool for building and testing web engine (#12197) bfa43e1 [flutter_runner] Generate symbols for the Dart VM profiler (#12048) 954f198 Add custom test plugin that supports screenshot tests (#12079) d8379f9 Move the Fuchsia tryjob into a its own step and disable LTO. (#12190) c12ac24 Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits) cab3a39 Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (#12178) 2592d6e [flutter_runner] Port the accessibility bridge from Topaz (#12054) b569e8c Smooth out iOS irregular input events delivery (#11817) dea813d Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits) 2438798 Make ImageShader implement Shader for web ui (#12161) c31583a Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits) 4542886 Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (#12151) 548998f Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (#12129) f1490a2 Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (#12106) 19b2d43 Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (#12088) d816755 Don't launch the observatory by default on each embedder unit-test invocation. (#12087) 39c8067 Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (#12086) b19e75a Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits) 03e773a Guard availability of user notification related methods to iOS 10.0 (#12084) 9c00c26 Add capability to add AppDelegate as UNUserNotificationCenterDelegate (#9864) c2e8289 Add GradientRadial paintStyle implementation (#12081) c3eea0a Don't quote generic font families (#12080) c2b3d88 Roll src/third_party/skia 28d40b2e7ade..c2d84bfa7421 (3 commits) (#12082) a4de006 Remove ENABLE_BITCODE from Scenarios test app (#11839) 6e017f0 Roll src/third_party/skia 4f2674da4bbc..28d40b2e7ade (4 commits) (#12077) e911b05 Roll src/third_party/skia 627d15588f4d..4f2674da4bbc (1 commits) (#12075) 359e663 Roll src/third_party/skia 6c3bd09ead0f..627d15588f4d (3 commits) (#12074) 38d545e Improve Unicode handling on Windows (#11899) 89efb4c Roll fuchsia/clang/linux-amd64 from VoYNW... to 2IT_b... (#12072) dc8e30d Roll fuchsia/clang/mac-amd64 from XAazI... to H1Qjc... (#12071) 8cdb3af Annotate nullability on FlutterEngine to make swift writing more ergonomic (#11808) aa9aaa2 Roll src/third_party/skia f433336585ed..6c3bd09ead0f (1 commits) (#12070) 075a61f Roll src/third_party/skia 69a426f5a427..f433336585ed (1 commits) (#12068) a610505 option for --no-lto for fuchsia (#12010) be39820 Roll src/third_party/skia 380561393385..69a426f5a427 (2 commits) (#12067) 6bafbf9 Roll src/third_party/skia c30f1a936d84..380561393385 (3 commits) (#12059) e2ba93d Roll src/third_party/dart ec7ec4ecf7..fb14babf59 (19 commits) 723a288 Roll fuchsia/clang/linux-amd64 from -mnHl... to VoYNW... (#12058) 35875e0 Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (#11798)" (#12055) a353f93 Manage resource and onscreen contexts using separate IOSGLContext objects (#11798) c9ea4db [flutter_runner] Refactor our build rules to make them more inline with topaz. (#12034) 50bdbd7 Document dependencies and remove support-v13 (#11912) 0c6a538 Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits) 37f81cd Roll src/third_party/skia 080d210e7acc..c30f1a936d84 (21 commits) (#12031)

There are overlapping TODAY issues (flutter#40303 and flutter#40114) that prevent this roll from being split up further. git log 7ea9884..3c6383f --no-merges --oneline 3c6383f Revert "Smooth out iOS irregular input events delivery (flutter#11817)" (flutter#12251) d6f0b64 pin and auto-install chrome version (flutter#12228) 2698a0e Roll fuchsia/sdk/core/mac-amd64 from Ne2UA... to JVZ_i... (flutter#12250) dfa9498 Enable platform view keyboard input on Android Q (flutter#12085) bf91a8d Roll fuchsia/sdk/core/linux-amd64 from u7Q31... to vuG5q... (flutter#12238) 58ecf52 Roll src/third_party/skia 7c47d41067d4..be194479d27f (4 commits) (flutter#12237) c71580b Roll dart to e6887536aadc7fbd1990448989601cee0224958d. (flutter#12235) cf1d156 Roll fuchsia/sdk/core/mac-amd64 from _nS67... to Ne2UA... (flutter#12236) bbb1f12 Adjust iOS frame start times to match the platform info (flutter#11802) 1de28d0 Roll src/third_party/skia 50f377e275c3..7c47d41067d4 (3 commits) (flutter#12231) da84d59 Revert "Manage iOS contexts separately (flutter#12078)" (flutter#12233) 4ac0663 Manage iOS contexts separately (flutter#12078) 28d7900 Roll src/third_party/skia 120e7d6766e4..50f377e275c3 (7 commits) (flutter#12224) 5b94c8a Revert "Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)" (flutter#12223) 988efe3 Do not generate kernel platform files on topaz tree (flutter#12222) 6c46a17 Don't disable toString in release mode for dart:ui classes (flutter#12204) 80b8ed8 Roll fuchsia/sdk/core/linux-amd64 from 7gDBN... to u7Q31... (flutter#12221) 7a8caaa Roll src/third_party/skia d96ef09317d6..120e7d6766e4 (2 commits) (flutter#12220) c8428ff Roll fuchsia/sdk/core/mac-amd64 from vDk46... to _nS67... (flutter#12219) 2bdfb61 Namespace patched SDK names to not conflict with Topaz (flutter#12218) ff1fcfb Roll src/third_party/dart ca7baa4013..4d5e15abde (29 commits) 2b78c59 Roll src/third_party/skia 14318c140949..d96ef09317d6 (2 commits) (flutter#12216) d74ed76 Roll src/third_party/skia b23a4f9d9442..14318c140949 (2 commits) (flutter#12215) c58c593 Roll src/third_party/skia 26ac0467cb4c..b23a4f9d9442 (2 commits) (flutter#12214) 5e85403 Roll src/third_party/dart 7bbfd532de..ca7baa4013 (3 commits) e2cc04c Roll fuchsia/sdk/core/linux-amd64 from R1yqu... to 7gDBN... (flutter#12212) 6fbfb45 Roll fuchsia/sdk/core/mac-amd64 from spUG2... to vDk46... (flutter#12210) 96443e2 Roll buildroot and Fuchsia toolchain and unblock the Fuchsia/Linux autoroller manually. (flutter#12209) 34cf4f7 Roll src/third_party/skia 4fe30e15c06c..26ac0467cb4c (2 commits) (flutter#12207) 92d42c0 Only build the x64 variant of Fuchsia on the try-jobs. (flutter#12206) e174b4b Don't load Roboto by default (flutter#12205) efb32a6 Roll src/third_party/dart 300c3333d1..7bbfd532de (5 commits) 5566be1 Roll src/third_party/skia 66d8006c2bb1..4fe30e15c06c (11 commits) (flutter#12202) e9c9984 add a convenience CLI tool for building and testing web engine (flutter#12197) bfa43e1 [flutter_runner] Generate symbols for the Dart VM profiler (flutter#12048) 954f198 Add custom test plugin that supports screenshot tests (flutter#12079) d8379f9 Move the Fuchsia tryjob into a its own step and disable LTO. (flutter#12190) c12ac24 Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits) cab3a39 Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (flutter#12178) 2592d6e [flutter_runner] Port the accessibility bridge from Topaz (flutter#12054) b569e8c Smooth out iOS irregular input events delivery (flutter#11817) dea813d Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits) 2438798 Make ImageShader implement Shader for web ui (flutter#12161) c31583a Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits) 4542886 Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (flutter#12151) 548998f Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (flutter#12129) f1490a2 Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (flutter#12106) 19b2d43 Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (flutter#12088) d816755 Don't launch the observatory by default on each embedder unit-test invocation. (flutter#12087) 39c8067 Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (flutter#12086) b19e75a Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits) 03e773a Guard availability of user notification related methods to iOS 10.0 (flutter#12084) 9c00c26 Add capability to add AppDelegate as UNUserNotificationCenterDelegate (flutter#9864) c2e8289 Add GradientRadial paintStyle implementation (flutter#12081) c3eea0a Don't quote generic font families (flutter#12080) c2b3d88 Roll src/third_party/skia 28d40b2e7ade..c2d84bfa7421 (3 commits) (flutter#12082) a4de006 Remove ENABLE_BITCODE from Scenarios test app (flutter#11839) 6e017f0 Roll src/third_party/skia 4f2674da4bbc..28d40b2e7ade (4 commits) (flutter#12077) e911b05 Roll src/third_party/skia 627d15588f4d..4f2674da4bbc (1 commits) (flutter#12075) 359e663 Roll src/third_party/skia 6c3bd09ead0f..627d15588f4d (3 commits) (flutter#12074) 38d545e Improve Unicode handling on Windows (flutter#11899) 89efb4c Roll fuchsia/clang/linux-amd64 from VoYNW... to 2IT_b... (flutter#12072) dc8e30d Roll fuchsia/clang/mac-amd64 from XAazI... to H1Qjc... (flutter#12071) 8cdb3af Annotate nullability on FlutterEngine to make swift writing more ergonomic (flutter#11808) aa9aaa2 Roll src/third_party/skia f433336585ed..6c3bd09ead0f (1 commits) (flutter#12070) 075a61f Roll src/third_party/skia 69a426f5a427..f433336585ed (1 commits) (flutter#12068) a610505 option for --no-lto for fuchsia (flutter#12010) be39820 Roll src/third_party/skia 380561393385..69a426f5a427 (2 commits) (flutter#12067) 6bafbf9 Roll src/third_party/skia c30f1a936d84..380561393385 (3 commits) (flutter#12059) e2ba93d Roll src/third_party/dart ec7ec4ecf7..fb14babf59 (19 commits) 723a288 Roll fuchsia/clang/linux-amd64 from -mnHl... to VoYNW... (flutter#12058) 35875e0 Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (flutter#11798)" (flutter#12055) a353f93 Manage resource and onscreen contexts using separate IOSGLContext objects (flutter#11798) c9ea4db [flutter_runner] Refactor our build rules to make them more inline with topaz. (flutter#12034) 50bdbd7 Document dependencies and remove support-v13 (flutter#11912) 0c6a538 Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits) 37f81cd Roll src/third_party/skia 080d210e7acc..c30f1a936d84 (21 commits) (flutter#12031)

Changes since last roll: ``` 6e6de94 Roll dart to d9489622befb638c040975163cf9b8eba2ff057b. (flutter#12255) 5c86111 [glfw/windows] Stops keeping track of input models (flutter#12234) 9c84659 Editable text fix (flutter#12249) cce4b5b Roll src/third_party/dart e6887536aa..c74e68e501 (14 commits) 55c346a Roll fuchsia/sdk/core/linux-amd64 from vuG5q... to 6a4X4... (flutter#12252) 6beba53 Started taking advantage of Skia's new copyTableData to avoid (flutter#10154) 3c6383f Revert "Smooth out iOS irregular input events delivery (flutter#11817)" (flutter#12251) d6f0b64 pin and auto-install chrome version (flutter#12228) 2698a0e Roll fuchsia/sdk/core/mac-amd64 from Ne2UA... to JVZ_i... (flutter#12250) dfa9498 Enable platform view keyboard input on Android Q (flutter#12085) bf91a8d Roll fuchsia/sdk/core/linux-amd64 from u7Q31... to vuG5q... (flutter#12238) 58ecf52 Roll src/third_party/skia 7c47d41067d4..be194479d27f (4 commits) (flutter#12237) c71580b Roll dart to e6887536aadc7fbd1990448989601cee0224958d. (flutter#12235) cf1d156 Roll fuchsia/sdk/core/mac-amd64 from _nS67... to Ne2UA... (flutter#12236) bbb1f12 Adjust iOS frame start times to match the platform info (flutter#11802) 1de28d0 Roll src/third_party/skia 50f377e275c3..7c47d41067d4 (3 commits) (flutter#12231) da84d59 Revert "Manage iOS contexts separately (flutter#12078)" (flutter#12233) 4ac0663 Manage iOS contexts separately (flutter#12078) 28d7900 Roll src/third_party/skia 120e7d6766e4..50f377e275c3 (7 commits) (flutter#12224) 5b94c8a Revert "Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)" (flutter#12223) 988efe3 Do not generate kernel platform files on topaz tree (flutter#12222) 6c46a17 Don't disable toString in release mode for dart:ui classes (flutter#12204) 80b8ed8 Roll fuchsia/sdk/core/linux-amd64 from 7gDBN... to u7Q31... (flutter#12221) 7a8caaa Roll src/third_party/skia d96ef09317d6..120e7d6766e4 (2 commits) (flutter#12220) c8428ff Roll fuchsia/sdk/core/mac-amd64 from vDk46... to _nS67... (flutter#12219) 2bdfb61 Namespace patched SDK names to not conflict with Topaz (flutter#12218) ff1fcfb Roll src/third_party/dart ca7baa4013..4d5e15abde (29 commits) 2b78c59 Roll src/third_party/skia 14318c140949..d96ef09317d6 (2 commits) (flutter#12216) d74ed76 Roll src/third_party/skia b23a4f9d9442..14318c140949 (2 commits) (flutter#12215) c58c593 Roll src/third_party/skia 26ac0467cb4c..b23a4f9d9442 (2 commits) (flutter#12214) 5e85403 Roll src/third_party/dart 7bbfd532de..ca7baa4013 (3 commits) e2cc04c Roll fuchsia/sdk/core/linux-amd64 from R1yqu... to 7gDBN... (flutter#12212) 6fbfb45 Roll fuchsia/sdk/core/mac-amd64 from spUG2... to vDk46... (flutter#12210) 96443e2 Roll buildroot and Fuchsia toolchain and unblock the Fuchsia/Linux autoroller manually. (flutter#12209) 34cf4f7 Roll src/third_party/skia 4fe30e15c06c..26ac0467cb4c (2 commits) (flutter#12207) 92d42c0 Only build the x64 variant of Fuchsia on the try-jobs. (flutter#12206) e174b4b Don't load Roboto by default (flutter#12205) efb32a6 Roll src/third_party/dart 300c3333d1..7bbfd532de (5 commits) 5566be1 Roll src/third_party/skia 66d8006c2bb1..4fe30e15c06c (11 commits) (flutter#12202) e9c9984 add a convenience CLI tool for building and testing web engine (flutter#12197) bfa43e1 [flutter_runner] Generate symbols for the Dart VM profiler (flutter#12048) 954f198 Add custom test plugin that supports screenshot tests (flutter#12079) d8379f9 Move the Fuchsia tryjob into a its own step and disable LTO. (flutter#12190) c12ac24 Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits) cab3a39 Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (flutter#12178) 2592d6e [flutter_runner] Port the accessibility bridge from Topaz (flutter#12054) b569e8c Smooth out iOS irregular input events delivery (flutter#11817) dea813d Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits) 2438798 Make ImageShader implement Shader for web ui (flutter#12161) c31583a Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits) 4542886 Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (flutter#12151) 548998f Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (flutter#12129) f1490a2 Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (flutter#12106) 19b2d43 Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (flutter#12088) d816755 Don't launch the observatory by default on each embedder unit-test invocation. (flutter#12087) 39c8067 Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (flutter#12086) b19e75a Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits) 03e773a Guard availability of user notification related methods to iOS 10.0 (flutter#12084) 9c00c26 Add capability to add AppDelegate as UNUserNotificationCenterDelegate (flutter#9864) c2e8289 Add GradientRadial paintStyle implementation (flutter#12081) c3eea0a Don't quote generic font families (flutter#12080) c2b3d88 Roll src/third_party/skia 28d40b2e7ade..c2d84bfa7421 (3 commits) (flutter#12082) a4de006 Remove ENABLE_BITCODE from Scenarios test app (flutter#11839) 6e017f0 Roll src/third_party/skia 4f2674da4bbc..28d40b2e7ade (4 commits) (flutter#12077) e911b05 Roll src/third_party/skia 627d15588f4d..4f2674da4bbc (1 commits) (flutter#12075) 359e663 Roll src/third_party/skia 6c3bd09ead0f..627d15588f4d (3 commits) (flutter#12074) 38d545e Improve Unicode handling on Windows (flutter#11899) 89efb4c Roll fuchsia/clang/linux-amd64 from VoYNW... to 2IT_b... (flutter#12072) dc8e30d Roll fuchsia/clang/mac-amd64 from XAazI... to H1Qjc... (flutter#12071) 8cdb3af Annotate nullability on FlutterEngine to make swift writing more ergonomic (flutter#11808) aa9aaa2 Roll src/third_party/skia f433336585ed..6c3bd09ead0f (1 commits) (flutter#12070) 075a61f Roll src/third_party/skia 69a426f5a427..f433336585ed (1 commits) (flutter#12068) a610505 option for --no-lto for fuchsia (flutter#12010) be39820 Roll src/third_party/skia 380561393385..69a426f5a427 (2 commits) (flutter#12067) 6bafbf9 Roll src/third_party/skia c30f1a936d84..380561393385 (3 commits) (flutter#12059) e2ba93d Roll src/third_party/dart ec7ec4ecf7..fb14babf59 (19 commits) 723a288 Roll fuchsia/clang/linux-amd64 from -mnHl... to VoYNW... (flutter#12058) 35875e0 Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (flutter#11798)" (flutter#12055) a353f93 Manage resource and onscreen contexts using separate IOSGLContext objects (flutter#11798) c9ea4db [flutter_runner] Refactor our build rules to make them more inline with topaz. (flutter#12034) 50bdbd7 Document dependencies and remove support-v13 (flutter#11912) 0c6a538 Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits) 37f81cd Roll src/third_party/skia 080d210e7acc..c30f1a936d84 (21 commits) (flutter#12031) ```

1b63444 Revert "Started taking advantage of Skia's new copyTableData to avoid (flutter#10154)" (flutter#12263) 0897b50 Roll fuchsia/sdk/core/linux-amd64 from 6a4X4... to Xfeuz... (flutter#12261) 186014c Roll src/third_party/skia be194479d27f..043dba039e0d (23 commits) (flutter#12262) 4debdda Roll fuchsia/sdk/core/mac-amd64 from JVZ_i... to gVBCH... (flutter#12260) 9e7bd05 Roll src/third_party/dart d9489622be..a554c8be6b (10 commits) 850d80c Revert "Add some AppLifecycleTests (flutter#11890)" (flutter#12264) 46ff053 Add some AppLifecycleTests (flutter#11890) ca4c3f6 Add an initial macOS version of FlutterAppDelegate (flutter#12230) 6e6de94 Roll dart to d9489622befb638c040975163cf9b8eba2ff057b. (flutter#12255) 5c86111 [glfw/windows] Stops keeping track of input models (flutter#12234) 9c84659 Editable text fix (flutter#12249) cce4b5b Roll src/third_party/dart e6887536aa..c74e68e501 (14 commits) 55c346a Roll fuchsia/sdk/core/linux-amd64 from vuG5q... to 6a4X4... (flutter#12252) 6beba53 Started taking advantage of Skia's new copyTableData to avoid (flutter#10154) 3c6383f Revert "Smooth out iOS irregular input events delivery (flutter#11817)" (flutter#12251) d6f0b64 pin and auto-install chrome version (flutter#12228) 2698a0e Roll fuchsia/sdk/core/mac-amd64 from Ne2UA... to JVZ_i... (flutter#12250) dfa9498 Enable platform view keyboard input on Android Q (flutter#12085) bf91a8d Roll fuchsia/sdk/core/linux-amd64 from u7Q31... to vuG5q... (flutter#12238) 58ecf52 Roll src/third_party/skia 7c47d41067d4..be194479d27f (4 commits) (flutter#12237) c71580b Roll dart to e6887536aadc7fbd1990448989601cee0224958d. (flutter#12235) cf1d156 Roll fuchsia/sdk/core/mac-amd64 from _nS67... to Ne2UA... (flutter#12236) bbb1f12 Adjust iOS frame start times to match the platform info (flutter#11802) 1de28d0 Roll src/third_party/skia 50f377e275c3..7c47d41067d4 (3 commits) (flutter#12231) da84d59 Revert "Manage iOS contexts separately (flutter#12078)" (flutter#12233) 4ac0663 Manage iOS contexts separately (flutter#12078) 28d7900 Roll src/third_party/skia 120e7d6766e4..50f377e275c3 (7 commits) (flutter#12224) 5b94c8a Revert "Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)" (flutter#12223) 988efe3 Do not generate kernel platform files on topaz tree (flutter#12222) 6c46a17 Don't disable toString in release mode for dart:ui classes (flutter#12204) 80b8ed8 Roll fuchsia/sdk/core/linux-amd64 from 7gDBN... to u7Q31... (flutter#12221) 7a8caaa Roll src/third_party/skia d96ef09317d6..120e7d6766e4 (2 commits) (flutter#12220) c8428ff Roll fuchsia/sdk/core/mac-amd64 from vDk46... to _nS67... (flutter#12219) 2bdfb61 Namespace patched SDK names to not conflict with Topaz (flutter#12218) ff1fcfb Roll src/third_party/dart ca7baa4013..4d5e15abde (29 commits) 2b78c59 Roll src/third_party/skia 14318c140949..d96ef09317d6 (2 commits) (flutter#12216) d74ed76 Roll src/third_party/skia b23a4f9d9442..14318c140949 (2 commits) (flutter#12215) c58c593 Roll src/third_party/skia 26ac0467cb4c..b23a4f9d9442 (2 commits) (flutter#12214) 5e85403 Roll src/third_party/dart 7bbfd532de..ca7baa4013 (3 commits) e2cc04c Roll fuchsia/sdk/core/linux-amd64 from R1yqu... to 7gDBN... (flutter#12212) 6fbfb45 Roll fuchsia/sdk/core/mac-amd64 from spUG2... to vDk46... (flutter#12210) 96443e2 Roll buildroot and Fuchsia toolchain and unblock the Fuchsia/Linux autoroller manually. (flutter#12209) 34cf4f7 Roll src/third_party/skia 4fe30e15c06c..26ac0467cb4c (2 commits) (flutter#12207) 92d42c0 Only build the x64 variant of Fuchsia on the try-jobs. (flutter#12206) e174b4b Don't load Roboto by default (flutter#12205) efb32a6 Roll src/third_party/dart 300c3333d1..7bbfd532de (5 commits) 5566be1 Roll src/third_party/skia 66d8006c2bb1..4fe30e15c06c (11 commits) (flutter#12202) e9c9984 add a convenience CLI tool for building and testing web engine (flutter#12197) bfa43e1 [flutter_runner] Generate symbols for the Dart VM profiler (flutter#12048) 954f198 Add custom test plugin that supports screenshot tests (flutter#12079) d8379f9 Move the Fuchsia tryjob into a its own step and disable LTO. (flutter#12190) c12ac24 Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits) cab3a39 Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (flutter#12178) 2592d6e [flutter_runner] Port the accessibility bridge from Topaz (flutter#12054) b569e8c Smooth out iOS irregular input events delivery (flutter#11817) dea813d Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits) 2438798 Make ImageShader implement Shader for web ui (flutter#12161) c31583a Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits) 4542886 Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (flutter#12151) 548998f Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (flutter#12129) f1490a2 Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (flutter#12106) 19b2d43 Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (flutter#12088) d816755 Don't launch the observatory by default on each embedder unit-test invocation. (flutter#12087) 39c8067 Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (flutter#12086) b19e75a Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits) 03e773a Guard availability of user notification related methods to iOS 10.0 (flutter#12084) 9c00c26 Add capability to add AppDelegate as UNUserNotificationCenterDelegate (flutter#9864) c2e8289 Add GradientRadial paintStyle implementation (flutter#12081) c3eea0a Don't quote generic font families (flutter#12080) c2b3d88 Roll src/third_party/skia 28d40b2e7ade..c2d84bfa7421 (3 commits) (flutter#12082) a4de006 Remove ENABLE_BITCODE from Scenarios test app (flutter#11839) 6e017f0 Roll src/third_party/skia 4f2674da4bbc..28d40b2e7ade (4 commits) (flutter#12077) e911b05 Roll src/third_party/skia 627d15588f4d..4f2674da4bbc (1 commits) (flutter#12075) 359e663 Roll src/third_party/skia 6c3bd09ead0f..627d15588f4d (3 commits) (flutter#12074) 38d545e Improve Unicode handling on Windows (flutter#11899) 89efb4c Roll fuchsia/clang/linux-amd64 from VoYNW... to 2IT_b... (flutter#12072) dc8e30d Roll fuchsia/clang/mac-amd64 from XAazI... to H1Qjc... (flutter#12071) 8cdb3af Annotate nullability on FlutterEngine to make swift writing more ergonomic (flutter#11808) aa9aaa2 Roll src/third_party/skia f433336585ed..6c3bd09ead0f (1 commits) (flutter#12070) 075a61f Roll src/third_party/skia 69a426f5a427..f433336585ed (1 commits) (flutter#12068) a610505 option for --no-lto for fuchsia (flutter#12010) be39820 Roll src/third_party/skia 380561393385..69a426f5a427 (2 commits) (flutter#12067) 6bafbf9 Roll src/third_party/skia c30f1a936d84..380561393385 (3 commits) (flutter#12059) e2ba93d Roll src/third_party/dart ec7ec4ecf7..fb14babf59 (19 commits) 723a288 Roll fuchsia/clang/linux-amd64 from -mnHl... to VoYNW... (flutter#12058) 35875e0 Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (flutter#11798)" (flutter#12055) a353f93 Manage resource and onscreen contexts using separate IOSGLContext objects (flutter#11798) c9ea4db [flutter_runner] Refactor our build rules to make them more inline with topaz. (flutter#12034) 50bdbd7 Document dependencies and remove support-v13 (flutter#11912) 0c6a538 Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits) 37f81cd Roll src/third_party/skia 080d210e7acc..c30f1a936d84 (21 commits) (flutter#12031)

Factor out flutter manifest logic

b4e0c35

szakarias requested a review from mravn-google September 25, 2017 08:52

googlebot added the cla: yes label Sep 25, 2017

move import up

c66652a

tvolkert reviewed Sep 25, 2017

View reviewed changes

mravn-google reviewed Sep 26, 2017

View reviewed changes

mravn-google approved these changes Sep 26, 2017

View reviewed changes

comments

58cd674

szakarias commented Sep 26, 2017

View reviewed changes

mravn-google approved these changes Sep 26, 2017

View reviewed changes

add curlies in if-else

ce334f4

szakarias merged commit 49ba974 into flutter:master Sep 26, 2017

tvolkert mentioned this pull request Sep 26, 2017

Run command validation on all commands. #12246

Merged

xster mentioned this pull request Oct 16, 2017

Bundle fonts from dependent packages #12160

Closed

mklim mentioned this pull request Sep 12, 2019

Roll engine from 7ea9884..3c6383f (77 commits 🔥) #40372

Merged

mklim mentioned this pull request Sep 13, 2019

Roll engine 7ea9884..1b6344439 (91 commits 🔥🔥🔥) #40442

Merged

github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021

		@@ -0,0 +1,174 @@
		// Copyright 2017 The Chromium Authors. All rights reserved.

Factor out flutter manifest logic #12237

Factor out flutter manifest logic #12237

Uh oh!

Conversation

szakarias commented Sep 25, 2017

Uh oh!

Hixie commented Sep 25, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mravn-google left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mravn-google left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

szakarias left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment