Revert PRs relating to single window assumption #122369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 10, 2023 05:18
This reverts commit c7681f0.
This reverts commit 6ec4445.
…est` (flutter#122233)" This reverts commit eb3d317.
flutter-dashboard
bot
added
a: tests
…tter#122352)" This reverts commit 927289f.
flutter-dashboard
bot
added
the
f: integration_test
added 2 commits
March 10, 2023 05:45
flutter#122325)" This reverts commit 67e17e4.
…indow` (flutter#122327)" This reverts commit c2a5111.
flutter-dashboard
bot
added
a: text input
added 2 commits
March 10, 2023 05:59
flutter#122347)" This reverts commit 28b65e0.
…w` (flutter#122321)" This reverts commit 01367d5.
XilaiZhang
approved these changes
Mar 10, 2023
Contributor
XilaiZhang
left a comment
XilaiZhang
left a comment
There was a problem hiding this comment.
wow.... correct me if i am wrong, are we reverting 8 prs?
flutter-dashboard
bot
added
the
a: internationalization
Contributor
Author
That's correct. The feature PR, and all cleanup PRs were landed back to back, which made this difficult to get back to a clean state. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
This was referenced Mar 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Mar 11, 2023
* Revert "Remove references to BindingBase.window (flutter#122119)" This reverts commit c7681f0. * Revert "Remove another reference to BindingBase.window (flutter#122341)" This reverts commit 6ec4445. * Revert "Reland (2): Removes single window assumptions from `flutter_test` (flutter#122233)" This reverts commit eb3d317. * Revert "Remove single view assumption from TestViewConfiguration (flutter#122352)" This reverts commit 927289f. * Revert "Updates `flutter/test/cupertino` to no longer use `TestWindow` (flutter#122325)" This reverts commit 67e17e4. * Revert "Updates `flutter/test/gestures` to no longer reference `TestWindow` (flutter#122327)" This reverts commit c2a5111. * Revert "Updates `flutter/test/rendering` to no longer use `TestWindow` (flutter#122347)" This reverts commit 28b65e0. * Revert "Updates `flutter_localizations/test` to stop using `TestWindow` (flutter#122321)" This reverts commit 01367d5.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the following:
flutter_test#122233flutter/test/gesturesto no longer referenceTestWindow#122327flutter/test/cupertinoto no longer useTestWindow#122325flutter/test/renderingto no longer useTestWindow#122347flutter_localizations/testto stop usingTestWindow#122321This is breaking Google Testing, see b/272640575.
Pre-launch Checklist
///).