Remove single view assumption from TestViewConfiguration #122352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: tests
goderbauer
force-pushed
the
TestViewCOnfiguration
branch
from
bc6a55b to
28709a9
Compare
goderbauer
added
the
autosubmit
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
Mar 10, 2023
…tter#122352)" This reverts commit 927289f.
8 tasks
CaseyHillers
pushed a commit
that referenced
this pull request
Mar 10, 2023
* Revert "Remove references to BindingBase.window (#122119)" This reverts commit c7681f0. * Revert "Remove another reference to BindingBase.window (#122341)" This reverts commit 6ec4445. * Revert "Reland (2): Removes single window assumptions from `flutter_test` (#122233)" This reverts commit eb3d317. * Revert "Remove single view assumption from TestViewConfiguration (#122352)" This reverts commit 927289f. * Revert "Updates `flutter/test/cupertino` to no longer use `TestWindow` (#122325)" This reverts commit 67e17e4. * Revert "Updates `flutter/test/gestures` to no longer reference `TestWindow` (#122327)" This reverts commit c2a5111. * Revert "Updates `flutter/test/rendering` to no longer use `TestWindow` (#122347)" This reverts commit 28b65e0. * Revert "Updates `flutter_localizations/test` to stop using `TestWindow` (#122321)" This reverts commit 01367d5.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
goderbauer
added a commit
to goderbauer/flutter
that referenced
this pull request
Mar 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Mar 11, 2023
* Revert "Remove references to BindingBase.window (flutter#122119)" This reverts commit c7681f0. * Revert "Remove another reference to BindingBase.window (flutter#122341)" This reverts commit 6ec4445. * Revert "Reland (2): Removes single window assumptions from `flutter_test` (flutter#122233)" This reverts commit eb3d317. * Revert "Remove single view assumption from TestViewConfiguration (flutter#122352)" This reverts commit 927289f. * Revert "Updates `flutter/test/cupertino` to no longer use `TestWindow` (flutter#122325)" This reverts commit 67e17e4. * Revert "Updates `flutter/test/gestures` to no longer reference `TestWindow` (flutter#122327)" This reverts commit c2a5111. * Revert "Updates `flutter/test/rendering` to no longer use `TestWindow` (flutter#122347)" This reverts commit 28b65e0. * Revert "Updates `flutter_localizations/test` to stop using `TestWindow` (flutter#122321)" This reverts commit 01367d5.
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Mar 11, 2023
…tter#122352)" (flutter#122414) Reland "Remove single view assumption from TestViewConfiguration (flutter#122352)"
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #116929.
TestViewConfiguration would default to the global window singleton. In a multi view world, that default doesn't make sense and users are required to explicitly specify which view the configuration is for.
All call sites already did specify the view explicitly, so the default didn't have much of a purpose anyways.