Take screenshot on devicelab failure #122249
Conversation
jmagman
added
the
c: contributor-productivity
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| if (dumpDirectory == null) { | ||
| return; | ||
| } | ||
| // On command failure try uploading screenshot of failing command. |
There was a problem hiding this comment.
Where does the actual uploading happen? Or do we already upload hostAgent.dumpDirectory if it exists?
There was a problem hiding this comment.
That directory is uploaded as part of the recipe. Anything we copy there is available in the log section of the build.
jmagman
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter, pr: 122249, due to - The status or check suite Linux gradle_plugin_light_apk_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
christopherfujino
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter, pr: 122249, due to - The status or check suite Linux gradle_plugin_light_apk_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
jmagman
added
the
autosubmit
2 participants
Help track down #120808 and other flakes by taking screenshots of device when
fluttercommands fail.