Skip to content

Conversation

@aam
Copy link
Member

@aam aam commented Sep 22, 2017

@aam aam requested a review from Hixie September 22, 2017 01:08
@cbracken
Copy link
Member

lgtm

@Hixie
Copy link
Contributor

Hixie commented Sep 22, 2017

This sets it to >=0.13.7 <1.0.0, it doesn't actually pin it; is that what you intended?

@aam
Copy link
Member Author

aam commented Sep 22, 2017

This sets it to >=0.13.7 <1.0.0, it doesn't actually pin it; is that what you intended?

@Hixie , I meant to pin to that range :-) Did you mean to pin it to exact one version? I think the range up to next semantic version should work fine - that is what we do for other packages.

@aam aam changed the title Pin args to 0.13.7 to avoid version conflict Pin args to [0.13.7-1.0.0) to avoid version conflict Sep 22, 2017
@Hixie
Copy link
Contributor

Hixie commented Sep 22, 2017

If it works, I'm fine with it.

I'm working on a script that will actually pin every dependency and transitive dependency to a single version, because any time we have a range, we eventually get skew and get broken like today. (There's nothing particularly special about today's breakage, it happens all the time, and is caused by different packages having different ranges. So ranges are always going to cause this.)

@aam aam merged commit 63802b3 into flutter:master Sep 22, 2017
@aam aam deleted the pin-args branch September 22, 2017 01:29
Hixie added a commit that referenced this pull request Sep 22, 2017
Hixie added a commit that referenced this pull request Sep 22, 2017
* Revert "Pin args to 0.13.7 to avoid version conflict (#12208)"

This reverts commit 63802b3.

* Revert "LinearGradient and RadialGradient RTL (#12204)"

This reverts commit daedbc8.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants