Skip to content

Add ZoomPageTransitionsBuilder.allowSnapshotting - #122019

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
NevercodeHQ:add_ZoomPageTransitionsBuilder_allowSnapshotting_property
Mar 6, 2023
Merged

auto-submit[bot] merged 1 commit into
flutter:masterfrom
NevercodeHQ:add_ZoomPageTransitionsBuilder_allowSnapshotting_property

Conversation

@bleroux

@bleroux bleroux commented Mar 6, 2023 •

Copy link
Copy Markdown
Contributor

Description

This PR adds ZoomPageTransitionsBuilder.allowSnapshotting property to make it possible to opt-out globally from zoom page transitions snapshotting. See #121701 (comment).

This PR also adds an example.

Related Issue

Fixes #122017

Tests

Adds 3 tests for the new property.
Adds 1 test for the new example.

@flutter-dashboard flutter-dashboard Bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also point out the ability to disable on a per route basis with route settings

@bleroux
bleroux force-pushed the add_ZoomPageTransitionsBuilder_allowSnapshotting_property branch from de259f2 to e4140fd Compare March 6, 2023 20:02

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bleroux
bleroux force-pushed the add_ZoomPageTransitionsBuilder_allowSnapshotting_property branch from e4140fd to 0885365 Compare March 6, 2023 20:27
@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2023
@auto-submit
auto-submit Bot merged commit 961df98 into flutter:master Mar 6, 2023
@bleroux
bleroux deleted the add_ZoomPageTransitionsBuilder_allowSnapshotting_property branch March 7, 2023 08:47
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a way to opt out from zoom page transition snapshotting.

2 participants