Reland: Add visual density for menu default style (#114878) #121918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
Contributor
|
The title should be "Reland: Add visual ..." (we try to avoid multiple Revert:'s because it gets really confusing to know if it's "in" or "out"). |
QuncCccccc
changed the title
Contributor
|
Were there any changes from the original PR? |
Contributor
Author
No. This is the same with the original PR. The scuba failure is because the test is for desktop and the compact visual density decreases the horizontal padding. So I'm going to attach a CL for the app to give it the default padding. |
QuncCccccc
deleted the
revert-121810-revert-114878-add_visualDensity_for_menu_default_style
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #121810
Fixes #114850
The scuba failure should be expected behavior because the compact visual density will cause the horizontal padding decrease to 8.0. Will attach a CL fix.