[flutter_tool] add enable-embedder-api flag #121895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 3, 2023 11:08
flutter-dashboard
bot
added
framework
jmagman
requested changes
Mar 3, 2023
| final int? hotEventReloadVMTimeInMs; // cd 55 | ||
| final bool? commandRunEnableImpeller; // cd 56 | ||
| final String? commandRunIOSInterfaceType; // cd 57 | ||
| final bool? commandRunEnableEmbedderApi; // cd 58 |
Member
There was a problem hiding this comment.
Do we really need to track this as usage data? I can't imagine more than one or two non-contributor customers ever running with this (as opposed to impeller).
packages/flutter_tools/lib/src/reporting/custom_dimensions.dart
Outdated
Show resolved
Hide resolved
|
|
||
| void addEnableEmbedderApiFlag({required bool verboseHelp}) { | ||
| argParser.addFlag('enable-embedder-api', | ||
| negatable: false, |
Member
There was a problem hiding this comment.
This should be negatable and default to false.
Comment on lines
1050
to
1052
| help: 'Whether to enable embedder api.' | ||
| 'This flag only currently supports iOS, it is' | ||
| 'ignored when targeting other platforms.', |
Member
There was a problem hiding this comment.
How about:
Suggested change
| help: 'Whether to enable embedder api.' | |
| 'This flag only currently supports iOS, it is' | |
| 'ignored when targeting other platforms.', | |
| help: 'Whether to enable the experimental embedder API on iOS.', |
Co-authored-by: Jenn Magder <[email protected]>
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is to enable the embedder api on iOS during iOS embedder api migration. Framework part of flutter/engine#40025
First step of #112232
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.