Skip to content

Fix path name to discover debug apk on add2app builds (#117999) #121881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
itsjustkevin merged 1 commit into from
Mar 8, 2023
Merged

Fix path name to discover debug apk on add2app builds (#117999) #121881

itsjustkevin merged 1 commit into from
Mar 8, 2023

Conversation

@burnermanx
Copy link

@burnermanx burnermanx commented Mar 3, 2023

Cherry-pick of 5dabe10 / #117999, to fix #121256 on the stable branch

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 3, 2023
@burnermanx burnermanx mentioned this pull request Mar 4, 2023
Closed
@reidbaker reidbaker self-requested a review March 6, 2023 19:04
@itsjustkevin itsjustkevin merged commit 33ab7b5 into flutter:flutter-3.7-candidate.1 Mar 8, 2023
@burnermanx burnermanx deleted the pr-cp-add2app-fix branch March 8, 2023 17:37
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2023
@engine-flutter-autoroll
33ab7b597 Fix path name to discover debug apk on add2app builds (#117…
a46a801 
…999) (flutter/flutter#121881)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@burnermanx @reidbaker @itsjustkevin @GaryQian