Skip to content

Conversation

@fluttergithubbot
Copy link
Contributor

This PR was generated by flutter update-packages --force-upgrade.

@fluttergithubbot fluttergithubbot added tool Affects the "flutter" command-line tool. See also t: labels. autosubmit Merge PR when tree becomes green via auto submit App labels Mar 3, 2023
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. team: flakes c: tech-debt Technical debt, code quality, testing, etc. labels Mar 3, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 3, 2023

auto label is removed for flutter/flutter, pr: 121847, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 3, 2023

auto label is removed for flutter/flutter, pr: 121847, due to Validations Fail.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 3, 2023

auto label is removed for flutter/flutter, pr: 121847, due to - The status or check suite Mac tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

collection: 1.17.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
cross_file: 0.3.3+4 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
flutter_plugin_android_lifecycle: 2.0.8 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
flutter_plugin_android_lifecycle: 2.0.9 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reidbaker could you take a look at this? This change appears to be causing the following failure (although I can't explain why it seems to have passed on Linux...)

[        ] Cause 1: org.gradle.internal.resolve.ModuleVersionResolveException: Could not resolve androidx.annotation:annotation:1.5.0.
[        ] Required by:
[        ]     project :flutter_plugin_android_lifecycle

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8787684536026999009/+/u/run_test.dart_for_tool_integration_tests_shard_and_subshard_4_4/test_stdout

Here is the changelog for this plugin: https://github.com/flutter/packages/commits/main/packages/flutter_plugin_android_lifecycle

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christopherfujino
Copy link
Contributor

The package that broke CI was manually pinned, so closing this

auto-submit bot pushed a commit that referenced this pull request Jun 14, 2023
Unpins flutter_plugin_android_lifecycle where it is pinned. I then 
1. ran `flutter update-packages --force-upgrade` (but only committed the changes within `dev/integration_tests/gradle_deprecated_settings/`, which is where it had been pinned) 
2. followed by `./gradlew :generateLockfiles` from `dev/integration_tests/gradle_deprecated_settings/android/` (the lockfile was what was causing the CI dependency resolution failure, so this second step is the fix for that).

See the reason it was pinned: #121847 (comment) followed by the PR that pinned it: #122043

Fixes #122039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants