flutter_tool: only enable wasm compile in master channel #121755
Conversation
flutter-dashboard
bot
added
the
tool
This comment was marked as outdated.
This comment was marked as outdated.
|
Need to wait on the parent PR to land, first |
kevmoo
force-pushed
the
wasm_experimental
branch
3 times, most recently
from
b3457bb to
3602381
Compare
kevmoo
changed the title
|
@christopherfujino – suggestions on adding tests for this? Or not needed? |
|
@eyebrowsoffire – the only thing I worry about here is |
Yeah, can you add a test here: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/features_test.dart |
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
nit about capitalization of JavaScript, otherwise LGTM
kevmoo
force-pushed
the
wasm_experimental
branch
from
bf0b573 to
dfd85e6
Compare
|
auto label is removed for flutter/flutter, pr: 121755, due to - The status or check suite Mac tool_integration_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
| /// All current Flutter feature flags that can be configured. | ||
| /// | ||
| /// [Feature.configSetting] is not `null`. | ||
| Iterable<Feature> get allConfigurableFeatures => allFeatures.where((Feature feature) => feature.configSetting != null); |
There was a problem hiding this comment.
@christopherfujino – seems there are a number of tests that assume every feature is configurable. Figured this was a clean way to address it.
3 participants
Added an associated
Feature