Skip to content

Remove customer testing from recipes cq. #121734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 1, 2023
Merged

Remove customer testing from recipes cq. #121734

auto-submit merged 1 commit into from
Mar 1, 2023

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Mar 1, 2023

Those tests are not adding value to recipes testing and they frequently block recipes CLs.

Bug: #121733

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Remove customer testing from recipes cq.
289caed 
Those tests are not adding value to recipes testing and they frequently
block recipes CLs.

Bug: #121733
@godofredoc godofredoc requested a review from keyonghan as a code owner March 1, 2023 20:48
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 1, 2023
@auto-submit auto-submit bot merged commit 888b7b9 into flutter:master Mar 1, 2023
@godofredoc godofredoc deleted the remove_customer_cq branch March 1, 2023 21:40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
888b7b9 Remove customer testing from recipes cq. (flutter/flutter#121734
10b4478 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
888b7b9 Remove customer testing from recipes cq. (flutter/flutter#121734
bbaca81 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
888b7b9 Remove customer testing from recipes cq. (flutter/flutter#121734
a918d55 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
888b7b9 Remove customer testing from recipes cq. (flutter/flutter#121734
032fd63 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
888b7b9 Remove customer testing from recipes cq. (flutter/flutter#121734
5270598 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
888b7b9 Remove customer testing from recipes cq. (flutter/flutter#121734
d0a87e8 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
888b7b9 Remove customer testing from recipes cq. (flutter/flutter#121734
a3eaece 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
888b7b9 Remove customer testing from recipes cq. (flutter/flutter#121734
4ef19f6 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
888b7b9 Remove customer testing from recipes cq. (flutter/flutter#121734
d7829d4 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
888b7b9 Remove customer testing from recipes cq. (flutter/flutter#121734
9cf4dea 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
888b7b9 Remove customer testing from recipes cq. (flutter/flutter#121734
8ebed83 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keyonghan keyonghan Awaiting requested review from keyonghan

@ricardoamador ricardoamador Awaiting requested review from ricardoamador

1 more reviewer

@yusuf-goog yusuf-goog yusuf-goog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @yusuf-goog