Skip to content

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Mar 1, 2023

Reland #120881 which was reverted in #121624
fixes #120650
fixes #74963 (while relanding this i also fixed it for iOS as I was already investigating a fix for IOS before it was reverted)

code sample
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      // showSemanticsDebugger: true,
      theme: ThemeData(useMaterial3: true),
      home: const Scaffold(
        body: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              ExpansionTile(
                title: Text('Flutter Forward'),
                children: <Widget>[
                  Column(
                    children: <Widget>[
                      Text('Text'),
                      Text('Text'),
                      Text('Text'),
                      Text('Text'),
                    ],
                  )
                ],
              ),
              SizedBox(height: 20),
              ExpansionTile(
                initiallyExpanded: true,
                title: Text('Flutter Forward'),
                children: <Widget>[
                  Column(
                    children: <Widget>[
                      Text('Text'),
                      Text('Text'),
                      Text('Text'),
                      Text('Text'),
                    ],
                  )
                ],
              ),
            ],
          ),
        ),
      ),
    );
  }
}

Regression fix

master regression this PR

Android Demo

VID_20230301172817.mp4

iOS demo

IMG_2241.MP4

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 1, 2023
@TahaTesser TahaTesser requested a review from chunhtai March 1, 2023 15:31
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for non localized string

@TahaTesser TahaTesser requested a review from chunhtai March 2, 2023 11:38
@TahaTesser TahaTesser closed this Mar 3, 2023
@TahaTesser
Copy link
Member Author

TahaTesser commented Mar 3, 2023

Closing to make a complete fix for all list tile variants in a single PR (as ExpansionTile is just using ListTile) to address all the issues in #121636

@TahaTesser TahaTesser removed the request for review from chunhtai March 3, 2023 09:11
@TahaTesser TahaTesser deleted the reland_expansion_tile_hint_fix branch March 27, 2023 10:47
@chunhtai chunhtai mentioned this pull request Apr 6, 2023
8 tasks
@jrescalona96
Copy link

Hi @chunhtai @TahaTesser! I'm running into this same issue in 3.7.12. Do we know when this change will be available? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

3 participants