Skip to content

[roll] Revert "Fix ExpansionTile double tap to collapse/expanded and expanded/collapsed states semantics announcements" #121624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
XilaiZhang merged 1 commit into from
Feb 28, 2023
Merged

[roll] Revert "Fix ExpansionTile double tap to collapse/expanded and expanded/collapsed states semantics announcements" #121624

XilaiZhang merged 1 commit into from
Feb 28, 2023

Conversation

@XilaiZhang
Copy link
Contributor

@XilaiZhang XilaiZhang commented Feb 28, 2023 •
edited
Loading

Reverts #120881

This PR merges nodes in some tests where the change wasn't expected.
There might be a better way to do this. Will revert for now.

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 28, 2023
gspencergoog
gspencergoog approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

chunhtai
chunhtai approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XilaiZhang XilaiZhang changed the title Revert "Fix ExpansionTile double tap to collapse/expanded and expanded/collapsed states semantics announcements" [roll] Revert "Fix ExpansionTile double tap to collapse/expanded and expanded/collapsed states semantics announcements" Feb 28, 2023
@chunhtai
Copy link
Contributor

chunhtai commented Feb 28, 2023

@TahaTesser This pr causes the entire expanded content and tile to merge. I think you can reproduce it when using something like a column with multiple text widget in the expanded content, and observe that the entire column will be merged after the pr

@TahaTesser
Copy link
Member

TahaTesser commented Feb 28, 2023

@TahaTesser This pr causes the entire expanded content and tile to merge. I think you can reproduce it when using something like a column with multiple text widget in the expanded content, and observe that the entire column will be merged after the pr

Thank you, I'll investigate it.

@XilaiZhang XilaiZhang merged commit 153fce4 into master Feb 28, 2023
@XilaiZhang XilaiZhang deleted the revert-120881-expansion_tile_semantics branch February 28, 2023 21:15
@TahaTesser TahaTesser mentioned this pull request Feb 28, 2023
Closed
XilaiZhang added a commit to XilaiZhang/flutter that referenced this pull request Mar 1, 2023
@XilaiZhang
Revert "Fix ExpansionTile hint for Android (flutter#120881)" (flutt…
7abb384 
…er#121624)

This reverts commit fd65fd1.
@XilaiZhang XilaiZhang mentioned this pull request Mar 1, 2023
Merged
XilaiZhang added a commit that referenced this pull request Mar 1, 2023
@XilaiZhang
Revert "Fix ExpansionTile hint for Android (#120881)" (#121624) (#1…
066ff5c 
…21649)

This reverts commit fd65fd1.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
d0cd25e 
…ter/flutter#121624)
@TahaTesser TahaTesser mentioned this pull request Mar 1, 2023
Closed
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
f67454f 
…ter/flutter#121624)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
1a33bf9 
…ter/flutter#121624)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
7d8f27f 
…ter/flutter#121624)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
440fdce 
…ter/flutter#121624)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
7c0984a 
…ter/flutter#121624)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
957b021 
…ter/flutter#121624)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
0e57179 
…ter/flutter#121624)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
cba154e 
…ter/flutter#121624)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
d5af9fc 
…ter/flutter#121624)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
dca0891 
…ter/flutter#121624)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
d1bc5ec 
…ter/flutter#121624)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
1e4542c 
…ter/flutter#121624)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
f9b152b 
…ter/flutter#121624)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
6af23be 
…ter/flutter#121624)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
38e7a92 
…ter/flutter#121624)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
4bc695b 
…ter/flutter#121624)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
153fce4 Revert "Fix ExpansionTile hint for Android (#120881)" (flut…
51681e5 
…ter/flutter#121624)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@XilaiZhang @chunhtai @TahaTesser @gspencergoog