Skip to content

[flutter_tool] advertise the default value for --dart2js-optimization #121621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Mar 1, 2023
Merged

[flutter_tool] advertise the default value for --dart2js-optimization #121621

auto-submit merged 4 commits into from
Mar 1, 2023

Conversation

@kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Feb 28, 2023

in flutter build web

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 28, 2023
@flutter-dashboard

This comment was marked as outdated.

Sign in to view
@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2023
@auto-submit

This comment was marked as outdated.

Sign in to view
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 28, 2023

auto label is removed for flutter/flutter, pr: 121621, due to Validations Fail.

harryterkelsen
harryterkelsen approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 28, 2023

auto label is removed for flutter/flutter, pr: 121621, due to - The status or check suite Mac module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2023
@auto-submit auto-submit bot merged commit 0cd6f1f into master Mar 1, 2023
@auto-submit auto-submit bot deleted the dart2js_opiti_docs branch March 1, 2023 01:17
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
bdbf06f 
…mization (flutter/flutter#121621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
89bc929 
…mization (flutter/flutter#121621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
d174a09 
…mization (flutter/flutter#121621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
8fecfe3 
…mization (flutter/flutter#121621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
a87bec0 
…mization (flutter/flutter#121621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
3a6bfa5 
…mization (flutter/flutter#121621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
491df06 
…mization (flutter/flutter#121621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
65a0631 
…mization (flutter/flutter#121621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
d14b7b3 
…mization (flutter/flutter#121621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
3437113 
…mization (flutter/flutter#121621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
c0177fe 
…mization (flutter/flutter#121621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
c0b9d2f 
…mization (flutter/flutter#121621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
6e8aa7e 
…mization (flutter/flutter#121621)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
cac26e0 
…mization (flutter/flutter#121621)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
339b5de 
…mization (flutter/flutter#121621)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
b57097b 
…mization (flutter/flutter#121621)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
fe3c4c2 
…mization (flutter/flutter#121621)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
0cd6f1f [flutter_tool] advertise the default value for --dart2js-opti…
b18b109 
…mization (flutter/flutter#121621)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harryterkelsen harryterkelsen harryterkelsen approved these changes

@eyebrowsoffire eyebrowsoffire Awaiting requested review from eyebrowsoffire

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevmoo @harryterkelsen