Skip to content

Update a TODO in dartdoc.dart #121620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 1, 2023
Merged

Update a TODO in dartdoc.dart #121620

auto-submit merged 1 commit into from
Mar 1, 2023

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Feb 28, 2023

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 28, 2023
@goderbauer goderbauer added the framework flutter/packages/flutter repository. See also f: labels. label Feb 28, 2023
@chunhtai chunhtai self-requested a review March 1, 2023 18:37
chunhtai
chunhtai approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 1, 2023
@auto-submit auto-submit bot merged commit cb12394 into flutter:master Mar 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
cb12394 Update a TODO in dartdoc.dart (flutter/flutter#121620)
c0f375f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
cb12394 Update a TODO in dartdoc.dart (flutter/flutter#121620)
1bf71bb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
cb12394 Update a TODO in dartdoc.dart (flutter/flutter#121620)
4d3a729
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
cb12394 Update a TODO in dartdoc.dart (flutter/flutter#121620)
833e9f6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
cb12394 Update a TODO in dartdoc.dart (flutter/flutter#121620)
24b84b6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
cb12394 Update a TODO in dartdoc.dart (flutter/flutter#121620)
ac89b85
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
cb12394 Update a TODO in dartdoc.dart (flutter/flutter#121620)
010131a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
cb12394 Update a TODO in dartdoc.dart (flutter/flutter#121620)
9f0fdbb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
cb12394 Update a TODO in dartdoc.dart (flutter/flutter#121620)
43d7c0c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
cb12394 Update a TODO in dartdoc.dart (flutter/flutter#121620)
8f3fcdd
@goderbauer goderbauer deleted the todo branch March 3, 2023 18:12
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
cb12394 Update a TODO in dartdoc.dart (flutter/flutter#121620)
a1df02b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
cb12394 Update a TODO in dartdoc.dart (flutter/flutter#121620)
eacf025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goderbauer @chunhtai