Fix how tests count open SemanticsHandles #121571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: accessibility
goderbauer
commented
Feb 28, 2023
Member
Author
There was a problem hiding this comment.
I removed this since SemanticsTester is not actually part of the public API. So, the hint could be a little confusing.
chunhtai
approved these changes
Feb 28, 2023
Contributor
There was a problem hiding this comment.
I assume this would change when there may be multiple pipeline owners?
Contributor
There was a problem hiding this comment.
I assume this change is to verify the new counting logic work correctly, should we create a new test instead of modifying the existing one?
Member
Author
There was a problem hiding this comment.
Added a test. Turns out, the logic was previously untested and contained a bug. Now some more tests that fail to clean up their semantics handle are failing. I'll have to look into that tomorrow.
Member
Author
There was a problem hiding this comment.
Done. Could you take another look at the new tests and the fixes?
goderbauer
force-pushed
the
semanticsHandleTests
branch
2 times, most recently
from
4a2d301 to
d024afc
Compare
goderbauer
force-pushed
the
semanticsHandleTests
branch
from
d024afc to
39e5314
Compare
flutter-dashboard
bot
added
a: text input
chunhtai
approved these changes
Feb 28, 2023
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, just some concern about removing the usage of teardown.
| group('Semantics', () { | ||
| testWidgets('day mode', (WidgetTester tester) async { | ||
| final SemanticsHandle semantics = tester.ensureSemantics(); | ||
| addTearDown(semantics.dispose); |
Contributor
There was a problem hiding this comment.
This is surprising. I always thought this was the better way to dispose resource
Member
Author
There was a problem hiding this comment.
Yeah, but the way our checks currently work they don't play nice with that. We should probably fix that at some point.
goderbauer
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #121289.
Part of #121573.
Properly count the open semantics handles in tests. In an ideal world we'd not have the PipelineOwner API for creating semantics handlers and would only be concerned about SemanticsHandlers created via the Binding. However, for backwards compatibility, we will also count the PipelineOwner handles for now (until we eventually deprecate that API).
This change also fixes the leak detection to work properly. Previously, it had an off by one error and was missing leaks. Tests have been added to prevent this in the future.